FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

feat(testing): add isConnected check by jsjoeio · Pull Request #3271 · coder/code-server · GitHub

/ code-server Public

feat(testing): add isConnected check - #3271

Merged
repo-ranger[bot] merged 2 commits into
mainfrom
jsjoeio/check-connection-e2e
Apr 30, 2021
ConversationCommits (2)ChecksFiles changed
Merged

feat(testing): add isConnected check#3271
repo-ranger[bot] merged 2 commits into
mainfrom
jsjoeio/check-connection-e2e

Conversation

jsjoeio commented Apr 30, 2021 •
edited
Loading

Copy link
Copy Markdown
Contributor

This PR adds a new check for e2e tests to ensure we have a connection.

Changes

  • add isConnected method to CodeServer
  • add e2e test for isConnected
  • refactor reloadUntilEditorIsVisible to reloadUntilEditorIsReady (checks visibility and connection)

Screenshots

Checklist

  • tested locally
  • added a test

Fixes #3270

jsjoeio self-assigned this Apr 30, 2021
jsjoeio added the testing Anything related to testing label Apr 30, 2021
jsjoeio added this to the v3.9.4 milestone Apr 30, 2021

codecov Bot commented Apr 30, 2021 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #3271 (dcdde3d) into main (0d9fe6f) will not change coverage.
The diff coverage is n/a.

❗ Current head dcdde3d differs from pull request most recent head cde3057. Consider uploading reports for the commit cde3057 to get more accurate results

@@           Coverage Diff           @@
##             main    #3271   +/-   ##
=======================================
  Coverage   46.90%   46.90%           
=======================================
  Files          23       23           
  Lines        1196     1196           
  Branches      237      237           
=======================================
  Hits          561      561           
  Misses        451      451           
  Partials      184      184

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0d9fe6f...cde3057. Read the comment docs.

jsjoeio force-pushed the jsjoeio/check-connection-e2e branch from 120caab to a5926aa Compare April 30, 2021 20:36
jsjoeio marked this pull request as ready for review April 30, 2021 20:37
jsjoeio requested a review from a team as a code owner April 30, 2021 20:37
jawnsy approved these changes Apr 30, 2021
View reviewed changes

jawnsy left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Nice!

Comment thread test/e2e/models/CodeServer.ts Outdated
jsjoeio force-pushed the jsjoeio/check-connection-e2e branch from dcdde3d to cde3057 Compare April 30, 2021 20:44
repo-ranger Bot merged commit f5a3033 into main Apr 30, 2021
repo-ranger Bot deleted the jsjoeio/check-connection-e2e branch April 30, 2021 21:00
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
jawnsy jawnsy approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

jsjoeio

Labels

testing Anything related to testing

Projects

None yet

Milestone

v3.10.0

Development

Successfully merging this pull request may close these issues.

[dev]: add check to e2e tests for connection

2 participants

Back | FazBrowse Home | New Git URL