feat(testing): add test for src/node/constants.ts - #3290
Merged
jsjoeio merged 2 commits intoMay 6, 2021
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
jsjoeio
force-pushed
the
jsjoeio/update-constants-test
branch
from
f6b2be2 to
bcb98a6
Compare
May 5, 2021 22:33
jsjoeio
force-pushed
the
jsjoeio/update-constants-test
branch
from
bcb98a6 to
027106a
Compare
May 5, 2021 22:34
Copy link
Copy Markdown
Codecov Report
@@ Coverage Diff @@
## main #3290 +/- ##
==========================================
- Coverage 57.54% 56.95% -0.59%
==========================================
Files 24 35 +11
Lines 1279 1703 +424
Branches 290 374 +84
==========================================
+ Hits 736 970 +234
- Misses 441 583 +142
- Partials 102 150 +48
Continue to review full report at Codecov.
|
Sorry, something went wrong.
jsjoeio
marked this pull request as ready for review
May 5, 2021 22:44
Copy link
Copy Markdown
Contributor
Author
Sorry, something went wrong.
code-asher
approved these changes
May 6, 2021
Comment thread
test/unit/constants.test.ts
Outdated
jsjoeio
force-pushed
the
jsjoeio/update-constants-test
branch
from
7f41e45 to
7870c0b
Compare
May 6, 2021 17:37
code-asher
reviewed
May 6, 2021
Comment thread
test/unit/constants.test.ts
Outdated
Comment thread
test/unit/constants.test.ts
Outdated
code-asher
reviewed
May 6, 2021
Comment thread
test/unit/constants.test.ts
Outdated
We were accidentally ignoring `node/routes` because we had "out" instead of "/out" in `coveragePathIgnorePatterns` which caused us to not collect coverage for those files. Now we do.
jsjoeio
force-pushed
the
jsjoeio/update-constants-test
branch
from
c8ed585 to
cb5ab48
Compare
May 6, 2021 18:53
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds additional testing for src/node/constants.ts, specifically checking that both commit and version return the correct values when defined in and missing from package.json.
Screenshot