refactor(ci): split audit from prebuild - #3298
Conversation
jsjoeio
left a comment
There was a problem hiding this comment.
One minor change (I think) but otherwise, this looks way better 🙌
Sorry, something went wrong.
| - name: Install dependencies | ||
| if: steps.cache-yarn.outputs.cache-hit != 'true' | ||
| run: yarn --frozen-lockfile | ||
|
|
There was a problem hiding this comment.
The codecov upload relies on the coverage being generated, which happens when we run the unit tests. So if this is a fresh checkout of the repo, you may need to add a step after install dependencies and before upload code coverage to run the unit tests.
Sorry, something went wrong.
There was a problem hiding this comment.
Ah, I'll revert that change if it depends on the unit tests in the first place.
Sorry, something went wrong.
There was a problem hiding this comment.
Feel free to add a comment too (apologies, I should have done that when I added it!)
Sorry, something went wrong.
There was a problem hiding this comment.
In hindsight it makes perfect sense that you need to run tests to know what coverage for the tests is like - I just didn't notice in a hurry, heh. Pushed before I could add a comment, fingers crossed its fine.
Sorry, something went wrong.
Move dependency audits from prebuild to their own jobs, so that an error does not affect the rest of the build/test process.
Codecov Report
@@ Coverage Diff @@
## main #3298 +/- ##
=======================================
Coverage 57.54% 57.54%
=======================================
Files 24 24
Lines 1279 1279
Branches 290 290
=======================================
Hits 736 736
Misses 441 441
Partials 102 102 Continue to review full report at Codecov.
|
Sorry, something went wrong.
jsjoeio
left a comment
There was a problem hiding this comment.
Good work!
Sorry, something went wrong.
Move dependency audits from prebuild to their own jobs, so that an error does not affect the rest of the build/test process.