FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Use ptyHostService by code-asher · Pull Request #3308 · coder/code-server · GitHub

/ code-server Public

Use ptyHostService - #3308

Merged
code-asher merged 2 commits into
coder:mainfrom
code-asher:pty-host-service
May 7, 2021
ConversationCommits (2)ChecksFiles changed
Merged

Use ptyHostService#3308
code-asher merged 2 commits into
coder:mainfrom
code-asher:pty-host-service

Conversation

code-asher commented May 7, 2021

Copy link
Copy Markdown
Member

Most of this was a straightforward replacement of our code with theirs
but I also removed getDefaultShellAndArgs since it seems the reference
implementation no longer does that either.

Fixes #2276.

code-asher requested a review from a team as a code owner May 7, 2021 16:27
Use ptyHostService
c416e9b 
Most of this was a straightforward replacement of our code with theirs
but I also removed `getDefaultShellAndArgs` since it seems the reference
implementation no longer does that either.

Fixes coder#2276.

codecov Bot commented May 7, 2021 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #3308 (19668b2) into main (b21a9af) will not change coverage.
The diff coverage is n/a.

❗ Current head 19668b2 differs from pull request most recent head bdb230b. Consider uploading reports for the commit bdb230b to get more accurate results

@@           Coverage Diff           @@
##             main    #3308   +/-   ##
=======================================
  Coverage   58.95%   58.95%           
=======================================
  Files          35       35           
  Lines        1703     1703           
  Branches      374      374           
=======================================
  Hits         1004     1004           
  Misses        561      561           
  Partials      138      138

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b21a9af...bdb230b. Read the comment docs.

oxy approved these changes May 7, 2021
View reviewed changes

oxy left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Really nice work, and win for maintainability! 🎉
Let's merge after e2e tests pass!

jsjoeio added the enhancement Some improvement that isn't a feature label May 7, 2021
jsjoeio modified the milestones: v3.9.5, v3.9.4 May 7, 2021
jsjoeio approved these changes May 7, 2021
View reviewed changes

jsjoeio left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Woo! Awesome work. Excited to see this in action 🎉

oxy self-requested a review May 7, 2021 18:16

oxy commented May 7, 2021

Copy link
Copy Markdown

Pulled locally, is failing with:

[IPC Library: Pty Host] Error: ENOENT: no such file or directory, open '/var/home/oxy/Downloads/code-server-3.9.3-linux-amd64/lib/vscode/out/vs/platform/terminal/node/ptyHostMain.js'

(Downloaded release package from CI)

oxy commented May 7, 2021

Copy link
Copy Markdown

Tested locally, and terminal + persistence now works! Woohoo!

oxy approved these changes May 7, 2021
View reviewed changes

oxy left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

🎉

code-asher merged commit 5d5ecdc into coder:main May 7, 2021
code-asher deleted the pty-host-service branch May 7, 2021 19:12
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers
jsjoeio jsjoeio approved these changes
oxy oxy approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

code-asher

Labels

enhancement Some improvement that isn't a feature

Projects

None yet

Milestone

v3.10.0

Development

Successfully merging this pull request may close these issues.

Persistant terminal session on tab refresh

3 participants

Back | FazBrowse Home | New Git URL