FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

fix(build): download correct cloud-agent for arch by oxy · Pull Request #3331 · coder/code-server · GitHub

/ code-server Public

fix(build): download correct cloud-agent for arch - #3331

Merged
oxy merged 1 commit into
mainfrom
oxy/cloud-agent-arm64
May 10, 2021
ConversationCommits (1)ChecksFiles changed
Merged

fix(build): download correct cloud-agent for arch#3331
oxy merged 1 commit into
mainfrom
oxy/cloud-agent-arm64

Conversation

oxy commented May 10, 2021

Copy link
Copy Markdown

Fixes the npm postinstall script, which is also used to download cloud-agent, to download based on the system architecture.

oxy requested a review from a team as a code owner May 10, 2021 07:21

codecov Bot commented May 10, 2021

Copy link
Copy Markdown

Codecov Report

Merging #3331 (6ffe388) into main (02a0e05) will not change coverage.
The diff coverage is n/a.

❗ Current head 6ffe388 differs from pull request most recent head d54da76. Consider uploading reports for the commit d54da76 to get more accurate results

@@           Coverage Diff           @@
##             main    #3331   +/-   ##
=======================================
  Coverage   58.95%   58.95%           
=======================================
  Files          35       35           
  Lines        1703     1703           
  Branches      374      374           
=======================================
  Hits         1004     1004           
  Misses        561      561           
  Partials      138      138

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 02a0e05...d54da76. Read the comment docs.

oxy self-assigned this May 10, 2021
oxy added this to the v3.10.0 milestone May 10, 2021
code-asher approved these changes May 10, 2021
View reviewed changes
Comment thread ci/build/npm-postinstall.sh
esac
}

ARCH="${NPM_CONFIG_ARCH:-$(detect_arch)}"

code-asher May 10, 2021

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

This is a big ol' nit but I'm thinking we should move this inside main to match OS.

oxy May 10, 2021

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Will look at it for 3.11/3.10.1 - tested this locally for both amd64/arm64, and don't want to shake things up with changes on release day

oxy merged commit 930b046 into main May 10, 2021
oxy deleted the oxy/cloud-agent-arm64 branch May 10, 2021 16:26
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

code-asher code-asher approved these changes

Assignees

oxy

Labels

None yet

Projects

None yet

Milestone

v3.10.0

Development

Successfully merging this pull request may close these issues.

2 participants

Back | FazBrowse Home | New Git URL