FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

chore: update CHANGELOG by jsjoeio · Pull Request #3354 · coder/code-server · GitHub

/ code-server Public

chore: update CHANGELOG - #3354

Merged
repo-ranger[bot] merged 4 commits into
mainfrom
jsjoeio/update-changelog
May 11, 2021
ConversationCommits (4)ChecksFiles changed
Merged

chore: update CHANGELOG#3354
repo-ranger[bot] merged 4 commits into
mainfrom
jsjoeio/update-changelog

Conversation

jsjoeio commented May 11, 2021

Copy link
Copy Markdown
Contributor

This PR updates the CHANGELOG.md by adding #3330

jsjoeio requested a review from a team as a code owner May 11, 2021 18:32

codecov Bot commented May 11, 2021 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #3354 (dc9182d) into main (74fbb42) will not change coverage.
The diff coverage is n/a.

❗ Current head dc9182d differs from pull request most recent head a7e6990. Consider uploading reports for the commit a7e6990 to get more accurate results

@@           Coverage Diff           @@
##             main    #3354   +/-   ##
=======================================
  Coverage   58.95%   58.95%           
=======================================
  Files          35       35           
  Lines        1703     1703           
  Branches      374      374           
=======================================
  Hits         1004     1004           
  Misses        561      561           
  Partials      138      138

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 82ce9d5...a7e6990. Read the comment docs.

jsjoeio self-assigned this May 11, 2021
jsjoeio added the docs Documentation related label May 11, 2021
jsjoeio added this to the v3.11.0 milestone May 11, 2021
oxy suggested changes May 11, 2021
View reviewed changes

oxy left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I think we can also fix the indentation here while we're at it! I can't believe I didn't catch this in review earlier >.<

Comment thread CHANGELOG.md Outdated
Comment thread CHANGELOG.md Outdated
jsjoeio requested a review from oxy May 11, 2021 18:58
oxy suggested changes May 11, 2021
View reviewed changes

oxy left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

We should also probably change ## -> ### for 3.10.0 and for the commented-out template 😅

jsjoeio requested a review from oxy May 11, 2021 19:04
oxy suggested changes May 11, 2021
View reviewed changes
Comment thread CHANGELOG.md Outdated
oxy approved these changes May 11, 2021
View reviewed changes

oxy left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

All looks good now!

jsjoeio force-pushed the jsjoeio/update-changelog branch from 0947130 to a7e6990 Compare May 11, 2021 23:17
repo-ranger Bot merged commit c89861f into main May 11, 2021
repo-ranger Bot deleted the jsjoeio/update-changelog branch May 11, 2021 23:33
code-asher pushed a commit that referenced this pull request May 12, 2021
chore: update CHANGELOG (#3354)
825a40e
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
oxy oxy approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

jsjoeio

Labels

docs Documentation related

Projects

None yet

Milestone

v3.10.1

Development

Successfully merging this pull request may close these issues.

2 participants

Back | FazBrowse Home | New Git URL