FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

docs(contributing): add commits section by jsjoeio · Pull Request #3377 · coder/code-server · GitHub

/ code-server Public

docs(contributing): add commits section - #3377

Merged
jsjoeio merged 2 commits into
mainfrom
jsjoeio/docs-clean-commits
May 14, 2021
ConversationCommits (2)ChecksFiles changed
Merged

docs(contributing): add commits section#3377
jsjoeio merged 2 commits into
mainfrom
jsjoeio/docs-clean-commits

Conversation

jsjoeio commented May 12, 2021 •
edited
Loading

Copy link
Copy Markdown
Contributor

This PR adds some note to CONTRIBUTING.md around clean commits.

Checklist

  • updated CHANGELOG.md

jsjoeio added this to the v3.11.0 milestone May 12, 2021
jsjoeio added the docs Documentation related label May 12, 2021
jsjoeio self-assigned this May 12, 2021
jsjoeio force-pushed the jsjoeio/docs-clean-commits branch from 071adbb to cf5efbb Compare May 12, 2021 22:25
jsjoeio marked this pull request as ready for review May 12, 2021 22:25
jsjoeio requested a review from a team as a code owner May 12, 2021 22:25
jawnsy reviewed May 12, 2021
View reviewed changes
Comment thread docs/CONTRIBUTING.md Outdated

codecov Bot commented May 12, 2021 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #3377 (60d71fe) into main (a7cf990) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #3377   +/-   ##
=======================================
  Coverage   59.21%   59.21%           
=======================================
  Files          35       35           
  Lines        1709     1709           
  Branches      379      379           
=======================================
  Hits         1012     1012           
  Misses        559      559           
  Partials      138      138

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a7cf990...60d71fe. Read the comment docs.

code-asher reviewed May 14, 2021
View reviewed changes
Comment thread docs/CONTRIBUTING.md Outdated

### Commits

We prefer a clean commit history. This means you should squash all commits before asking for review (cleanup, squash, force-push). If you need help with this, feel free to leave a comment in your PR and we'll guide you.

code-asher May 14, 2021

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

squash all commits == PRs should only have one commit? Or does that just mean to squash fixups and fixup-type commits?

jsjoeio May 14, 2021

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Squash fixups and fixup-type commits - let me reword to clarify! Good point.

jsjoeio May 14, 2021

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

fixed!

jsjoeio force-pushed the jsjoeio/docs-clean-commits branch from ece723c to 0209e9f Compare May 14, 2021 20:24
jsjoeio force-pushed the jsjoeio/docs-clean-commits branch from 0209e9f to 60d71fe Compare May 14, 2021 20:50
jsjoeio enabled auto-merge May 14, 2021 20:50
jsjoeio merged commit 509d91d into main May 14, 2021
jsjoeio deleted the jsjoeio/docs-clean-commits branch May 14, 2021 20:54
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

code-asher code-asher approved these changes
+1 more reviewer
jawnsy jawnsy left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

jsjoeio

Labels

docs Documentation related

Projects

None yet

Milestone

v3.10.1

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL