FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

docs: add Pomerium by desimone · Pull Request #3424 · coder/code-server · GitHub

/ code-server Public

docs: add Pomerium - #3424

Merged
jsjoeio merged 5 commits into
coder:mainfrom
desimone:patch-1
May 24, 2021
ConversationCommits (5)ChecksFiles changed
Merged

docs: add Pomerium#3424
jsjoeio merged 5 commits into
coder:mainfrom
desimone:patch-1

Conversation

desimone commented May 20, 2021

Copy link
Copy Markdown
Contributor

RE: pomerium/pomerium#2223

Checklist

  • updated CHANGELOG.md

desimone requested a review from a team as a code owner May 20, 2021 00:23
jsjoeio added the docs Documentation related label May 20, 2021
jsjoeio added this to the 3.11.0 milestone May 20, 2021
jsjoeio suggested changes May 20, 2021
View reviewed changes

jsjoeio left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Thanks for adding this! 🙌

One minor issue with URL (I think)

Comment thread docs/FAQ.md Outdated

codecov Bot commented May 20, 2021 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #3424 (75e495c) into main (c6d5da1) will not change coverage.
The diff coverage is n/a.

❗ Current head 75e495c differs from pull request most recent head a86c9af. Consider uploading reports for the commit a86c9af to get more accurate results

@@           Coverage Diff           @@
##             main    #3424   +/-   ##
=======================================
  Coverage   59.21%   59.21%           
=======================================
  Files          35       35           
  Lines        1709     1709           
  Branches      379      379           
=======================================
  Hits         1012     1012           
  Misses        559      559           
  Partials      138      138

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c6d5da1...a86c9af. Read the comment docs.

Update docs/FAQ.md
c1bc464 
Co-authored-by: Joe Previte <jjprevite@gmail.com>
jsjoeio approved these changes May 21, 2021
View reviewed changes

jsjoeio left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM! Thanks so much @desimone 👍🏼

jsjoeio added the new contributor For PRs by first-time contributor label May 21, 2021

repo-ranger Bot commented May 21, 2021

Copy link
Copy Markdown
Contributor

Thanks for making your first contribution! 🙂

jsjoeio commented May 21, 2021

Copy link
Copy Markdown
Contributor

If you want to update the CHANGELOG with your change under "New Version" > "Documentation", then we'll make sure to credit you in the Release Notes for this update. Not required though :)

jsjoeio self-assigned this May 21, 2021
jsjoeio modified the milestones: 3.10.2, 3.11.0 May 21, 2021
jsjoeio changed the title Add Pomerium docs: add Pomerium May 24, 2021
jsjoeio enabled auto-merge May 24, 2021 21:28
jsjoeio mentioned this pull request May 24, 2021
Merged
1 task
jsjoeio merged commit 5c42b7c into coder:main May 24, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
jsjoeio jsjoeio approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

jsjoeio

Labels

docs Documentation related new contributor For PRs by first-time contributor

Projects

None yet

Milestone

3.11.0

Development

Successfully merging this pull request may close these issues.

2 participants

Back | FazBrowse Home | New Git URL