| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
Sorry, something went wrong.
|
Thanks for making your first contribution! 🙂 |
Sorry, something went wrong.
|
Thanks for fixing this! @shiv-tyagi 🎉 We would love to make sure you get credit in the next release. Do you mind updating the CHANGELOG? (and also updating/rebasing your branch) |
Sorry, something went wrong.
Codecov Report
@@ Coverage Diff @@
## main #3460 +/- ##
=======================================
Coverage 59.21% 59.21%
=======================================
Files 35 35
Lines 1709 1709
Branches 379 379
=======================================
Hits 1012 1012
Misses 559 559
Partials 138 138 Continue to review full report at Codecov.
|
Sorry, something went wrong.
|
It's my pleasure to contribute to the community. As I am a complete beginner to open source, can you guide me a bit about how to update CHANGELOG? |
Sorry, something went wrong.
|
Sure thing! The CHANGELOG lives at the root of the repo here. We ask that contributors add a line there to note their PR change. This saves us time for cutting releases because then we can copy the changes and use in the release notes.
(P.S. planning to add more docs about updating the CHANGELOG so it will be easier in the future.) |
Sorry, something went wrong.
|
I have committed the changes in changelog. Please review the same. If anything needs to be changed, please let me know. |
Sorry, something went wrong.
There was a problem hiding this comment.
Looks great! Thanks again @shiv-tyagi 🎉
Sorry, something went wrong.
|
Apologies @shiv-tyagi - can you please run yarn fmt locally and push up your changes? I would do it, but it doesn't seem like I can unless you check the box "Allow edits from maintainers" https://docs.github.com/en/github/collaborating-with-issues-and-pull-requests/working-with-forks/allowing-changes-to-a-pull-request-branch-created-from-a-fork |
Sorry, something went wrong.
|
I have allowed edits from maintainers. I can't figure it out what 'yarn fmt' and how to do this. It would be great if you elaborate a bit more @jsjoeio . |
Sorry, something went wrong.
I figured it out. I installed yarn locally and then I did run 'yarn fmt'. It made some changes in CHANGELOG.md . I hope I did it correctly @jsjoeio . |
Sorry, something went wrong.
Head branch was pushed to by a user without write access
|
Hooray! (Sorry I should have elaborated). Glad you got it though! I think it should be good then! |
Sorry, something went wrong.
| Back | FazBrowse Home | New Git URL |
This PR fixes a sentence in Pull request section which was less understandable on the first go.
Checklist