FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

fix(ci): disable trivy-scan-image by jsjoeio · Pull Request #3461 · coder/code-server · GitHub

/ code-server Public

fix(ci): disable trivy-scan-image - #3461

Merged
jsjoeio merged 2 commits into
mainfrom
jsjoeio/fix-3459
May 24, 2021
ConversationCommits (2)ChecksFiles changed
Merged

fix(ci): disable trivy-scan-image#3461
jsjoeio merged 2 commits into
mainfrom
jsjoeio/fix-3459

Conversation

jsjoeio commented May 24, 2021 •
edited
Loading

Copy link
Copy Markdown
Contributor

This PR temporarily disables trivy-scan-image due to an upstream issue. See: github/codeql-action#528

There was a vulnerability found when CI ran. This is fixed as well:

  • browserslist

Checklist

  • updated CHANGELOG.md

Fixes #3459

jsjoeio self-assigned this May 24, 2021
jsjoeio added the ci Issues related to ci label May 24, 2021
jsjoeio added this to the 3.11.0 milestone May 24, 2021

codecov Bot commented May 24, 2021 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #3461 (35f57e5) into main (99542e6) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #3461   +/-   ##
=======================================
  Coverage   59.21%   59.21%           
=======================================
  Files          35       35           
  Lines        1709     1709           
  Branches      379      379           
=======================================
  Hits         1012     1012           
  Misses        559      559           
  Partials      138      138

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 99542e6...35f57e5. Read the comment docs.

jsjoeio force-pushed the jsjoeio/fix-3459 branch from d4f853c to ff93932 Compare May 24, 2021 21:02
jsjoeio changed the title wip: fix codeql-action/upload -sarif fix(ci): disable trivy-scan-image May 24, 2021
jsjoeio marked this pull request as ready for review May 24, 2021 21:04
jsjoeio requested a review from a team as a code owner May 24, 2021 21:04
jsjoeio enabled auto-merge May 24, 2021 21:21
jawnsy reviewed May 24, 2021
View reviewed changes
Comment thread package.json
"doctoc/**/trim": "^1.0.0",
"postcss": "^8.2.1",
"parcel-bundler/cssnano": "^5.0.2",
"browserslist": "^4.16.5",

jawnsy May 24, 2021

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I think it's best to keep unrelated changes in separate PRs, otherwise the commit message is misleading

jsjoeio May 24, 2021

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I generally agree. But CI was failing for this PR. For fixing vulnerability updates, should we merge even if CI is failing and then submit a follow-up PR?

jsjoeio merged commit c6d5da1 into main May 24, 2021
jsjoeio deleted the jsjoeio/fix-3459 branch May 24, 2021 21:27
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
jawnsy jawnsy approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

jsjoeio

Labels

ci Issues related to ci

Projects

None yet

Milestone

3.11.0

Development

Successfully merging this pull request may close these issues.

github/codeql-action/upload-sarif - JavaScript heap out of memory

2 participants

Back | FazBrowse Home | New Git URL