FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

chore: update node to v14 by oxy · Pull Request #3481 · coder/code-server · GitHub

/ code-server Public

chore: update node to v14 - #3481

Merged
oxy merged 1 commit into
mainfrom
oxy/update-node
Jun 1, 2021
ConversationCommits (1)ChecksFiles changed
Merged

chore: update node to v14#3481
oxy merged 1 commit into
mainfrom
oxy/update-node

Conversation

oxy commented May 26, 2021

Copy link
Copy Markdown

Closes #3458; updates node and adds some process notes.

Checklist

  • updated CHANGELOG.md

oxy requested a review from a team as a code owner May 26, 2021 16:48
oxy force-pushed the oxy/update-node branch from 8d5b3bc to cf2e1e5 Compare May 26, 2021 17:08

codecov Bot commented May 26, 2021 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #3481 (86d4cad) into main (c2a8634) will not change coverage.
The diff coverage is n/a.

❗ Current head 86d4cad differs from pull request most recent head 19cbddb. Consider uploading reports for the commit 19cbddb to get more accurate results

@@           Coverage Diff           @@
##             main    #3481   +/-   ##
=======================================
  Coverage   59.21%   59.21%           
=======================================
  Files          35       35           
  Lines        1709     1709           
  Branches      379      379           
=======================================
  Hits         1012     1012           
  Misses        559      559           
  Partials      138      138

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c2a8634...19cbddb. Read the comment docs.

code-asher requested changes May 26, 2021
View reviewed changes

code-asher left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Very fast!

Comment thread ci/build/npm-postinstall.sh Outdated
oxy force-pushed the oxy/update-node branch 2 times, most recently from 5587bc3 to d7ed1a8 Compare May 28, 2021 18:19
oxy requested a review from code-asher May 28, 2021 18:20
oxy force-pushed the oxy/update-node branch 4 times, most recently from f620e2b to ebab9b0 Compare May 28, 2021 18:36
code-asher requested changes May 28, 2021
View reviewed changes

code-asher left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Minor typo, otherwise this looks excellent!

Comment thread docs/CONTRIBUTING.md Outdated
oxy requested a review from code-asher May 31, 2021 15:26
oxy force-pushed the oxy/update-node branch from 854652a to 19cbddb Compare June 1, 2021 15:31
oxy merged commit 58622cc into main Jun 1, 2021
oxy deleted the oxy/update-node branch June 1, 2021 17:19
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

code-asher code-asher approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Update to Node 14

2 participants

Back | FazBrowse Home | New Git URL