chore(dev): remove parcel - #3614
Merged
jsjoeio merged 1 commit intoJun 18, 2021
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
jsjoeio
commented
Jun 15, 2021
Comment thread
ci/build/build-code-server.sh
Comment thread
ci/build/build-code-server.sh
Outdated
Comment thread
ci/dev/watch.ts
Comment thread
ci/dev/watch.ts
Comment thread
package.json
Comment thread
src/browser/pages/vscode.html
Outdated
code-asher
reviewed
Jun 15, 2021
Comment thread
tsconfig.json
code-asher
reviewed
Jun 15, 2021
code-asher
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
-3308 lines, I like it.
Sorry, something went wrong.
code-asher
reviewed
Jun 15, 2021
Comment thread
ci/build/build-code-server.sh
Outdated
jsjoeio
force-pushed
the
jsjoeio/remove-parcel
branch
from
edda6a7 to
63e8c96
Compare
June 16, 2021 17:30
jsjoeio
marked this pull request as ready for review
June 16, 2021 17:31
Copy link
Copy Markdown
Contributor
Author
|
@code-asher ready for a second review 🎉 |
Sorry, something went wrong.
1 task
code-asher
requested changes
Jun 17, 2021
Comment thread
ci/build/build-code-server.sh
Outdated
Comment thread
ci/build/build-code-server.sh
Comment thread
ci/dev/watch.ts
Outdated
Comment thread
ci/dev/watch.ts
Outdated
Comment thread
src/browser/pages/login.html
Outdated
Comment thread
src/browser/pages/vscode.html
Outdated
Comment thread
src/browser/pages/vscode.ts
Outdated
Comment thread
package.json
jsjoeio
force-pushed
the
jsjoeio/remove-parcel
branch
2 times, most recently
from
bc349b5 to
43c21fb
Compare
June 17, 2021 22:59
jsjoeio
force-pushed
the
jsjoeio/remove-parcel
branch
from
43c21fb to
7afdcb4
Compare
June 17, 2021 23:01
code-asher
approved these changes
Jun 18, 2021
code-asher
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
🔥
Sorry, something went wrong.
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After trying to fix many issues with upgrading to Parcel 2, we're thinking it may be easier to remove it completely.
Checklist