Add VSCODE_PROXY_URI env var to extension host and terminal by code-asher · Pull Request #3621 · coder/code-server · GitHub

Checklist

Update CHANGELOG.md
Get proxy path from the client instead of req.headers.host.
Expose VSCODE_PROXY_URI to plugins
Expose VSCODE_PROXY_URI to terminal

Codecov Report

Merging #3621 (fea63fe) into main (92d0d28) will increase coverage by 0.44%.
The diff coverage is 90.47%.

❗ Current head fea63fe differs from pull request most recent head ecb29c4. Consider uploading reports for the commit ecb29c4 to get more accurate results

@@            Coverage Diff             @@
##             main    #3621      +/-   ##
==========================================
+ Coverage   64.94%   65.39%   +0.44%     
==========================================
  Files          36       36              
  Lines        1880     1887       +7     
  Branches      381      381              
==========================================
+ Hits         1221     1234      +13     
+ Misses        560      555       -5     
+ Partials       99       98       -1

Impacted Files	Coverage Δ
src/node/cli.ts	81.48% <71.42%> (+1.48%)	⬆️
src/common/util.ts	100.00% <100.00%> (ø)
src/node/util.ts	83.24% <0.00%> (+1.52%)	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 92d0d28...ecb29c4. Read the comment docs.

Currently on hold since I will need to rebase this on 1.57.

@code-asher remind me and @jawnsy that we should write a test for the webview fix we did here: #3895 after this gets merged

bump @code-asher - anything I can do to help get these unblocked and ready to merge?

Uh I forgot about this, I will rebase today.

@code-asher and I spoke offline about this. If we can get this in this week before Wednesday, great! But most likely shooting for the next release.

bump @code-asher -> think we'll be able to get this PR rebased, updated and marked ready this week?

Tentatively yes.

This will let us test extension-related features (like the proxy URI). I removed the environment variables in the script because they override the ones you set yourself. We still set defaults in constants.ts.

This way it can be called multiple times without incurring extra overhead or potentially resolving in a different way. Also catch any errors when parsing query options just as we do with the options in the markup and log errors with the latter as well.

This should not be merged as-is since it points to my fork.

Man, we really need to fix #4027.

This is failing because your PR is from a fork (yet you're a maintainer and have access to m) 😢

All good to go, blocked by coder/vscode#3

Besides the conflicting files, is there anything blocking this?

(Happy to pick it up as well)

I think it is just conflicts. I will get it sorted on Monday!

Let me know if you need help moving this forward!

Too many changes and branch out-of-date. We'll see if we can get this ready for the next release.

@code-asher what do you think about this PR? Is it at the end of it's life?

I think we can rebase it once 4.0.0 is stable.

I will re-open this when it is ready to go.

code-asher force-pushed the http-referer branch 3 times, most recently from 50d677b to 9cc76cc Compare June 16, 2021 22:21

code-asher force-pushed the http-referer branch from 9cc76cc to ea6a86b Compare June 21, 2021 18:39

code-asher changed the title Http referer Add VSCODE_PROXY_URI env var to extension host and terminal Jun 21, 2021

code-asher force-pushed the http-referer branch 3 times, most recently from 6d91937 to c0f7b0e Compare June 21, 2021 20:10

code-asher added the blocked This issue cannot proceed due to external factors label Jun 22, 2021

jsjoeio mentioned this pull request Aug 9, 2021

fix(lib/vscode): remove symlink in npm package #3935

Merged

code-asher removed the blocked This issue cannot proceed due to external factors label Aug 25, 2021

code-asher force-pushed the http-referer branch from c0f7b0e to 3513a0c Compare August 25, 2021 19:09

jsjoeio added this to the 3.12.1 milestone Sep 13, 2021

benz0li mentioned this pull request Sep 16, 2021

Modify function browser / argument url (options) to allow proxied requests REditorSupport/vscode-R#275

Closed

code-asher force-pushed the http-referer branch 3 times, most recently from 7f8f2e6 to e91e201 Compare September 27, 2021 20:06

code-asher added 4 commits September 29, 2021 18:37

Add test extension

12dc606

This will let us test extension-related features (like the proxy URI). I removed the environment variables in the script because they override the ones you set yourself. We still set defaults in constants.ts.

Cache options parsing

e068299

This way it can be called multiple times without incurring extra overhead or potentially resolving in a different way. Also catch any errors when parsing query options just as we do with the options in the markup and log errors with the latter as well.

Add changelog entry for VSCODE_PROXY_URI

a4fa599

[WIP] Update VS Code

ecb29c4

This should not be merged as-is since it points to my fork.

code-asher force-pushed the http-referer branch from e91e201 to ecb29c4 Compare September 29, 2021 18:38

code-asher mentioned this pull request Sep 29, 2021

Add VSCODE_PROXY_URI environment variable coder/vscode#3

Closed

jsjoeio modified the milestones: 3.12.1 - improve release process, 3.12.2 - improve iPad UX Nov 1, 2021

jsjoeio requested review from GirlBossRush and removed request for GirlBossRush November 29, 2021 20:42

jsjoeio assigned code-asher Nov 29, 2021

code-asher closed this Dec 17, 2021

jsjoeio removed this from the 4.1.0 - improve iPad UX milestone Jan 7, 2022

Add VSCODE_PROXY_URI env var to extension host and terminal by code-asher · Pull Request #3621 · coder/code-server · GitHub

Uh oh!

Add VSCODE_PROXY_URI env var to extension host and terminal - #3621

Add VSCODE_PROXY_URI env var to extension host and terminal#3621code-asher wants to merge 4 commits intocoder:maincoder/code-server:mainfrom code-asher:http-referercode-asher/code-server:http-refererCopy head branch name to clipboard

Conversation

code-asher commented Jun 16, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Checklist

Uh oh!

codecov Bot commented Jun 16, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

code-asher commented Jun 22, 2021

Uh oh!

jsjoeio commented Aug 5, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jsjoeio commented Aug 24, 2021

Uh oh!

code-asher commented Aug 25, 2021 via email • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jsjoeio commented Sep 13, 2021

Uh oh!

jsjoeio commented Sep 20, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

code-asher commented Sep 20, 2021 via email

Uh oh!

jsjoeio commented Sep 29, 2021

Uh oh!

code-asher commented Sep 29, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jsjoeio commented Oct 29, 2021

Uh oh!

code-asher commented Oct 29, 2021 via email

Uh oh!

jsjoeio commented Nov 2, 2021

Uh oh!

jsjoeio commented Dec 8, 2021

Uh oh!

jsjoeio commented Dec 14, 2021

Uh oh!

code-asher commented Dec 15, 2021 via email

Uh oh!

code-asher commented Dec 17, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Add VSCODE_PROXY_URI env var to extension host and terminal#3621
code-asher wants to merge 4 commits into
coder:mainfrom
code-asher:http-referer

code-asher commented Jun 16, 2021 •
edited
Loading

codecov Bot commented Jun 16, 2021 •
edited
Loading

jsjoeio commented Aug 5, 2021 •
edited
Loading

code-asher commented Aug 25, 2021 via email •
edited
Loading

jsjoeio commented Sep 20, 2021 •
edited
Loading

code-asher commented Sep 29, 2021 •
edited
Loading