FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

chore: update guides.md header to Accessing Web Services by khorne3 · Pull Request #3819 · coder/code-server · GitHub

/ code-server Public

chore: update guides.md header to Accessing Web Services - #3819

Merged
khorne3 merged 1 commit into
mainfrom
headers-fix
Jul 20, 2021
ConversationCommits (1)ChecksFiles changed
Merged

chore: update guides.md header to Accessing Web Services#3819
khorne3 merged 1 commit into
mainfrom
headers-fix

Conversation

khorne3 commented Jul 20, 2021

Copy link
Copy Markdown
Contributor

Fixes header on guides.md so that it reads "Accessing Web Services" instead of "Self signed certificates." Also updates in-text mention from "web service" to "web services."

khorne3 requested a review from a team as a code owner July 20, 2021 14:11

codecov Bot commented Jul 20, 2021

Copy link
Copy Markdown

Codecov Report

Merging #3819 (9d6a154) into main (475ae45) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #3819   +/-   ##
=======================================
  Coverage   62.05%   62.05%           
=======================================
  Files          36       36           
  Lines        1863     1863           
  Branches      378      378           
=======================================
  Hits         1156     1156           
  Misses        601      601           
  Partials      106      106

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 475ae45...9d6a154. Read the comment docs.

jsjoeio approved these changes Jul 20, 2021
View reviewed changes

jsjoeio left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Awesome! Thanks for fixing this @khorne3 🎉

jsjoeio added the docs Documentation related label Jul 20, 2021
jsjoeio added this to the 3.12.0 milestone Jul 20, 2021
khorne3 merged commit a84dd25 into main Jul 20, 2021
khorne3 deleted the headers-fix branch July 20, 2021 18:14

khorne3 commented Jul 20, 2021

Copy link
Copy Markdown
Contributor Author

oops @jsjoeio not sure if that merged to the right place; please let me know if I need to revert so we can fix

jsjoeio commented Jul 20, 2021

Copy link
Copy Markdown
Contributor

@khorne3 i'll let you decide. before it was in FAQ, now you have it in Guide. Totally up to you!

khorne3 commented Jul 20, 2021

Copy link
Copy Markdown
Contributor Author

@jsjoeio ah sorry for the confusion; I just saw that you added it to 3.12.0 milestone and wasn't sure if this is ok to go into main?

jsjoeio commented Jul 20, 2021

Copy link
Copy Markdown
Contributor

Oh! It's okay to go into main. 3.11 was already released so that's why I added it to 3.12. We use the milestones to associate issues/PRs that were done in that cycle. Sorry for the confusion!

jsjoeio modified the milestones: 3.12.0, 3.11.1 Aug 6, 2021
ahmadyahya11 mentioned this pull request Aug 8, 2021
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
jsjoeio jsjoeio approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

docs Documentation related

Projects

None yet

Milestone

3.11.1

Development

Successfully merging this pull request may close these issues.

2 participants

Back | FazBrowse Home | New Git URL