FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

chore: Update dependency requirements. Fix node version manager. by GirlBossRush · Pull Request #3831 · coder/code-server · GitHub

/ code-server Public

chore: Update dependency requirements. Fix node version manager. - #3831

Merged
GirlBossRush merged 1 commit into
mainfrom
chore-update-contributing
Jul 21, 2021
ConversationCommits (1)ChecksFiles changed
Merged

chore: Update dependency requirements. Fix node version manager.#3831
GirlBossRush merged 1 commit into
mainfrom
chore-update-contributing

Conversation

GirlBossRush commented Jul 21, 2021

Copy link
Copy Markdown
Contributor

This PR addresses some minor doc changes, and adds files that allow NVM and nodenv to automatically switch to our preferred version.

GirlBossRush added docs Documentation related enhancement Some improvement that isn't a feature chore Related to maintenance or clean up labels Jul 21, 2021
GirlBossRush requested a review from jsjoeio July 21, 2021 18:16
GirlBossRush self-assigned this Jul 21, 2021
GirlBossRush requested a review from a team as a code owner July 21, 2021 18:16
GirlBossRush commented Jul 21, 2021
View reviewed changes
Comment thread .nvmrc
@@ -0,0 +1 @@
.node-version No newline at end of file

GirlBossRush Jul 21, 2021

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Included as a symlink to avoid version drifting between NVM and nodenv

GirlBossRush commented Jul 21, 2021
View reviewed changes
Comment thread docs/CONTRIBUTING.md

- `node` v14.x
- `git` v2.x or greater
- [`git-lfs`](https://git-lfs.github.com)

GirlBossRush Jul 21, 2021

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I encountered a somewhat mysterious error when building the project on a clean slate. Turns out we need this too!

jawnsy approved these changes Jul 21, 2021
View reviewed changes
Comment thread .node-version
@@ -0,0 +1 @@
14

jawnsy Jul 21, 2021

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I dunno anything about nvm, though I'm curious why these tools don't inspect package.json's engine info for this?

Seems like a reasonable change to me though!

jsjoeio Jul 21, 2021

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Agreed, you would think it would be smarter!

GirlBossRush Jul 21, 2021

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Ahh, open source 😆

codecov Bot commented Jul 21, 2021

Copy link
Copy Markdown

Codecov Report

Merging #3831 (47999de) into main (0f45152) will not change coverage.
The diff coverage is n/a.

❗ Current head 47999de differs from pull request most recent head 709a0d0. Consider uploading reports for the commit 709a0d0 to get more accurate results

@@           Coverage Diff           @@
##             main    #3831   +/-   ##
=======================================
  Coverage   62.05%   62.05%           
=======================================
  Files          36       36           
  Lines        1863     1863           
  Branches      378      378           
=======================================
  Hits         1156     1156           
  Misses        601      601           
  Partials      106      106

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0f45152...709a0d0. Read the comment docs.

jsjoeio approved these changes Jul 21, 2021
View reviewed changes

jsjoeio left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Awesome work! Thanks for updating all this 🎉

Comment thread .node-version
@@ -0,0 +1 @@
14

jsjoeio Jul 21, 2021

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Agreed, you would think it would be smarter!

jsjoeio added this to the 3.12.0 milestone Jul 21, 2021

jsjoeio commented Jul 21, 2021 •
edited
Loading

Copy link
Copy Markdown
Contributor

Minor note: if your PR isn't related to an issue, add the Milestone on the right side so we associate this work with the next release. I don't think it's as explicit as it should be in the docs, but more info here: https://coder.com/docs/code-server/v3.10.2/MAINTAINING#project-boards

GirlBossRush enabled auto-merge (rebase) July 21, 2021 18:22
GirlBossRush merged commit dfc88e3 into main Jul 21, 2021
GirlBossRush deleted the chore-update-contributing branch July 21, 2021 18:32
jsjoeio modified the milestones: 3.12.0, 3.11.1 Aug 6, 2021
ahmadyahya11 mentioned this pull request Aug 8, 2021
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers
jawnsy jawnsy approved these changes
jsjoeio jsjoeio approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

GirlBossRush

Labels

chore Related to maintenance or clean up docs Documentation related enhancement Some improvement that isn't a feature

Projects

None yet

Milestone

3.11.1

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL