FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

docs(install): add uninstall instructions by jsjoeio · Pull Request #3840 · coder/code-server · GitHub

/ code-server Public

docs(install): add uninstall instructions - #3840

Merged
jsjoeio merged 1 commit into
mainfrom
jsjoeio-uninstall-docs
Jul 26, 2021
ConversationCommits (1)ChecksFiles changed
Merged

docs(install): add uninstall instructions#3840
jsjoeio merged 1 commit into
mainfrom
jsjoeio-uninstall-docs

Conversation

jsjoeio commented Jul 22, 2021 •
edited
Loading

Copy link
Copy Markdown
Contributor

This PR adds an "Uninstall" section to the install.md docs. I decied to add this because I noticed a trend in GitHub Discusions where people have asked how to do this:

Caveat

This does not cover all scenarios but it does cover the ones that have been asked about. I figured we can add more as it gets asked (issue/discussion drive development?).

Todos

jsjoeio self-assigned this Jul 22, 2021
jsjoeio added the docs Documentation related label Jul 22, 2021
jsjoeio added this to the 3.12.0 milestone Jul 22, 2021
jsjoeio commented Jul 22, 2021
View reviewed changes
Comment thread docs/install.md Outdated

### install.sh

If you installed with the install script, by default code-server will be in `~/usr/lib/code-server` and you can remove it with `rm -rf`. e.g.

jsjoeio Jul 22, 2021

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

❓ Is ~/usr/lib/code-server the right path? 🤔

jsjoeio Jul 22, 2021

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

According to install.sh

The release is unarchived into ~/.local/lib/code-server-X.X.X
and the binary symlinked into ~/.local/bin/code-server

So no that is not right.

jsjoeio Jul 22, 2021

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Updated for the unarchived. Wondering if we also need to tell them to remove the binary in /bin

codecov Bot commented Jul 22, 2021 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #3840 (4f2fd5a) into main (5b5a1f4) will not change coverage.
The diff coverage is n/a.

❗ Current head 4f2fd5a differs from pull request most recent head 162f70a. Consider uploading reports for the commit 162f70a to get more accurate results

@@           Coverage Diff           @@
##             main    #3840   +/-   ##
=======================================
  Coverage   62.60%   62.60%           
=======================================
  Files          36       36           
  Lines        1872     1872           
  Branches      379      379           
=======================================
  Hits         1172     1172           
  Misses        595      595           
  Partials      105      105

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5b5a1f4...162f70a. Read the comment docs.

jsjoeio marked this pull request as ready for review July 22, 2021 23:18
jsjoeio requested a review from a team as a code owner July 22, 2021 23:18
GirlBossRush reviewed Jul 26, 2021
View reviewed changes
Comment thread docs/install.md Outdated
GirlBossRush approved these changes Jul 26, 2021
View reviewed changes

GirlBossRush left a comment •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Some minor nits but otherwise this is a great addition. It would be especially nice if we could follow up with a programmatic means to identify the installation path e.g.

code-server --installation-prefix
code-server --config-prefix

jsjoeio commented Jul 26, 2021 •
edited
Loading

Copy link
Copy Markdown
Contributor Author 
code-server --installation-prefix
code-server --config-prefix

I think I understand what you mean, but to be extra clear, you're suggesting adding these as flags/args to run with code-server to identify these things as an end user? Fantastic idea! I'll open a separate issue to document.

jsjoeio force-pushed the jsjoeio-uninstall-docs branch from f17bab5 to 5e45a93 Compare July 26, 2021 17:51
jsjoeio mentioned this pull request Jul 26, 2021
Closed
jsjoeio force-pushed the jsjoeio-uninstall-docs branch from 5e45a93 to 162f70a Compare July 26, 2021 17:55
jsjoeio enabled auto-merge July 26, 2021 17:55
jsjoeio merged commit 3969a39 into main Jul 26, 2021
jsjoeio deleted the jsjoeio-uninstall-docs branch July 26, 2021 18:11
jsjoeio modified the milestones: 3.12.0, 3.11.1 Aug 6, 2021
ahmadyahya11 mentioned this pull request Aug 8, 2021
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
GirlBossRush GirlBossRush approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

jsjoeio

Labels

docs Documentation related

Projects

None yet

Milestone

3.11.1

Development

Successfully merging this pull request may close these issues.

2 participants

Back | FazBrowse Home | New Git URL