FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

feat: add more tests for proxy.ts by jsjoeio · Pull Request #3858 · coder/code-server · GitHub

/ code-server Public

feat: add more tests for proxy.ts - #3858

Merged
jsjoeio merged 2 commits into
mainfrom
jsjoeio-add-proxy-test
Jul 29, 2021
ConversationCommits (2)ChecksFiles changed
Merged

feat: add more tests for proxy.ts#3858
jsjoeio merged 2 commits into
mainfrom
jsjoeio-add-proxy-test

Conversation

jsjoeio commented Jul 26, 2021 •
edited
Loading

Copy link
Copy Markdown
Contributor

This PR adds more tests for proxy.ts, specifically to test that our proxy handles error events appropriately.

Fixes N/A

P.S. huge shoutout to @vapurrmaid for pairing with me on this 🎉

codecov Bot commented Jul 26, 2021 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #3858 (19fa7cf) into main (7e43f7d) will increase coverage by 0.10%.
The diff coverage is n/a.

❗ Current head 19fa7cf differs from pull request most recent head 9137816. Consider uploading reports for the commit 9137816 to get more accurate results

@@            Coverage Diff             @@
##             main    #3858      +/-   ##
==========================================
+ Coverage   63.40%   63.51%   +0.10%     
==========================================
  Files          36       36              
  Lines        1872     1872              
  Branches      379      379              
==========================================
+ Hits         1187     1189       +2     
+ Misses        582      580       -2     
  Partials      103      103
Impacted Files Coverage Δ
src/node/proxy.ts 100.00% <0.00%> (+22.22%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7e43f7d...9137816. Read the comment docs.

jsjoeio self-assigned this Jul 26, 2021

jsjoeio commented Jul 26, 2021

Copy link
Copy Markdown
Contributor Author

cc @code-asher would love to get your eyes on this and help me understand what I'm missing

greyscaled reviewed Jul 27, 2021
View reviewed changes
Comment thread test/unit/proxy.test.ts
jsjoeio added the testing Anything related to testing label Jul 27, 2021
jsjoeio added this to the 3.12.0 milestone Jul 27, 2021
jsjoeio force-pushed the jsjoeio-add-proxy-test branch from 1655625 to a86f3df Compare July 27, 2021 19:06
jsjoeio commented Jul 27, 2021
View reviewed changes
Comment thread test/unit/proxy.test.ts
Comment thread test/unit/proxy.test.ts Outdated
jsjoeio marked this pull request as ready for review July 27, 2021 19:09
jsjoeio requested a review from a team as a code owner July 27, 2021 19:09
jsjoeio mentioned this pull request Jul 27, 2021
Closed
jsjoeio force-pushed the jsjoeio-add-proxy-test branch from 8390c7c to 9eca6a5 Compare July 27, 2021 21:25
greyscaled reviewed Jul 27, 2021
View reviewed changes
Comment thread test/unit/helpers.test.ts
jsjoeio force-pushed the jsjoeio-add-proxy-test branch from 9eca6a5 to 07f6647 Compare July 27, 2021 22:51
oxy approved these changes Jul 29, 2021
View reviewed changes

oxy left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Looks good to me! ✨

jsjoeio force-pushed the jsjoeio-add-proxy-test branch from 07f6647 to 9137816 Compare July 29, 2021 22:17
jsjoeio enabled auto-merge July 29, 2021 22:17
jsjoeio merged commit ff3b188 into main Jul 29, 2021
jsjoeio deleted the jsjoeio-add-proxy-test branch July 29, 2021 22:33
jsjoeio modified the milestones: 3.12.0, 3.11.1 Aug 6, 2021
ahmadyahya11 mentioned this pull request Aug 8, 2021
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers
greyscaled greyscaled approved these changes
oxy oxy approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

jsjoeio

Labels

testing Anything related to testing

Projects

None yet

Milestone

3.11.1

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL