FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

refactor: clean up test file structure by jsjoeio · Pull Request #3866 · coder/code-server · GitHub

/ code-server Public

refactor: clean up test file structure - #3866

Merged
jsjoeio merged 1 commit into
mainfrom
jsjoeio-reorg-test-files
Jul 29, 2021
ConversationCommits (1)ChecksFiles changed
Merged

refactor: clean up test file structure#3866
jsjoeio merged 1 commit into
mainfrom
jsjoeio-reorg-test-files

Conversation

jsjoeio commented Jul 27, 2021

Copy link
Copy Markdown
Contributor

This PR cleans up the test file structure to match /src.

jsjoeio requested a review from a team as a code owner July 27, 2021 23:53
jsjoeio added the chore Related to maintenance or clean up label Jul 27, 2021
jsjoeio self-assigned this Jul 27, 2021
jsjoeio added this to the 3.12.0 milestone Jul 27, 2021
jsjoeio changed the title refactor: match /test/unit structure to /src refactor: clean up test file structure Jul 27, 2021
jsjoeio added the testing Anything related to testing label Jul 27, 2021

jsjoeio commented Jul 28, 2021 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Now this is confusing. Everything passes locally. I am not sure why the unit tests are failing in CI 🤔

@code-asher helped me figure it out. Forgot to update the typings alias in the tsconfig.json in the test plugin.

codecov Bot commented Jul 28, 2021 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #3866 (807e475) into main (7a5c457) will not change coverage.
The diff coverage is n/a.

❗ Current head 807e475 differs from pull request most recent head 7a6ec20. Consider uploading reports for the commit 7a6ec20 to get more accurate results

@@           Coverage Diff           @@
##             main    #3866   +/-   ##
=======================================
  Coverage   63.40%   63.40%           
=======================================
  Files          36       36           
  Lines        1872     1872           
  Branches      379      379           
=======================================
  Hits         1187     1187           
  Misses        582      582           
  Partials      103      103

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7a5c457...7a6ec20. Read the comment docs.

jsjoeio force-pushed the jsjoeio-reorg-test-files branch from 231f91f to 7a6ec20 Compare July 29, 2021 16:48
oxy approved these changes Jul 29, 2021
View reviewed changes

oxy left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Looks neat! 🚀 for organization

jsjoeio merged commit 7e43f7d into main Jul 29, 2021
jsjoeio deleted the jsjoeio-reorg-test-files branch July 29, 2021 22:14
jsjoeio modified the milestones: 3.12.0, 3.11.1 Aug 6, 2021
ahmadyahya11 mentioned this pull request Aug 8, 2021
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
oxy oxy approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

jsjoeio

Labels

chore Related to maintenance or clean up testing Anything related to testing

Projects

None yet

Milestone

3.11.1

Development

Successfully merging this pull request may close these issues.

2 participants

Back | FazBrowse Home | New Git URL