Summary

This reverts commit b32b4ed.

We are reverting this because we found out that while this fixes the postinstall
on Windows, it breaks it on mac and other devices.

See: #3874 (comment)

Additional Context

This change came in #4116 came from @MaxLOh with the goal of:

Currently, Windows default script-shell (cmd) fails to run the postinstall script.

This commit fixes the problem by running postinstall.sh explicitly with the default bash executable of the OS.

While that fixed the postinstall issue on Windows, it broke it for anyone installing with Homebrew since our formula does not depend on bash. Instead of modifying the formula, we are opting for reverting b32b4ed and using sh instead.

Our reasoning is that if someone on Windows has bash, surely they have sh as well.

Note: we don't know how @MaxLOh was actually installing code-server so we don't have an exact way to test for their situation but this should work. I had also proposed doing this:

"scripts": {
      "postinstall": "[ $(command -v bash) >/dev/null ] && bash ./postinstall.sh || ./postinstall.sh"
    }

but that assumes the person has command installed Windows which may or may not be the case.

We think we should also try to add some tests for this, which we may do in a follow-up PR.

Todos

• open up follow-up issue Add test for postinstall script  #4232

Fixes #3874
Fixes #4209