Update node to 10.15.1 by code-asher · Pull Request #472 · coder/code-server · GitHub

Fixes Use nbin for native modules #425
Fixes Markdown preview not working #296
Fixes Directory being made upon opening file (.ts) #432

as long as the docker file builds

whoops meant to approve

Adding wip tag because it's not running correctly when I build it with Docker.

Wasn't related to Docker, the spdlog dependencies needed to be included since it's external now. But there is another issue where bindings tries to look for the package.json and fails. It fails finding anything in /node_modules/spdlog, but those files appear to be included when bundling. 😕 Everything works now including Docker...except it seems to exit without any errors once the page loads. Edit: ah, it's a segfault. The shared process also continually exits with no errors and no exit code (probably segfaulting). <-- fixed by coder/nbin#5

It keeps using my already-built .node files which results in a mismatching GLIBC version error.

Blocked on coder/nbin#5.

+1 updating past node.js 10.10 will get you nodejs/node#22609 which might help when running code-server in mesos with a randomly assigned uid/gid that doesnt exist

I pulled the branch and tried it and I’m getting errors on startup

On Mon, Apr 15, 2019 at 2:47 PM Kyle Carberry ***@***.***> wrote: ***@***.**** approved this pull request. — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#472 (review)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAYDvzCeK5yuqWsAZ91JE0UtYMijjUfqks5vhMk0gaJpZM4clGE5> .

-- Raymond "VisualPhoenix" Barbiero

@visualphoenix What platform are you on? What errors are you receiving?

Just pulled the branch, built the docker container, and tried to launch it.

On Mon, Apr 15, 2019 at 2:53 PM Forest Hoffman ***@***.***> wrote: @visualphoenix <https://github.com/visualphoenix> What platform are you on? What errors are you receiving? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#472 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAYDv1pYvDE-mWkLxynqutYlYDSk_Eidks5vhMqzgaJpZM4clGE5> .

-- Raymond "VisualPhoenix" Barbiero

I’ll get you the error when I’m back at a computer. It was a bounds check error on startup On Mon, Apr 15, 2019 at 6:15 PM Raymond Barbiero <raymond.barbiero@gmail.com> wrote:

Just pulled the branch, built the docker container, and tried to launch it. On Mon, Apr 15, 2019 at 2:53 PM Forest Hoffman ***@***.***> wrote: > @visualphoenix <https://github.com/visualphoenix> What platform are you > on? What errors are you receiving? > > — > You are receiving this because you were mentioned. > > > Reply to this email directly, view it on GitHub > <#472 (comment)>, > or mute the thread > <https://github.com/notifications/unsubscribe-auth/AAYDv1pYvDE-mWkLxynqutYlYDSk_Eidks5vhMqzgaJpZM4clGE5> > . > -- Raymond "VisualPhoenix" Barbiero

-- Raymond "VisualPhoenix" Barbiero

@visualphoenix if you could open an issue with the error you're getting, that would be fantastic. Thank you!

* Update Node to 10.15.1 * Remove string replace that was used for oclif * Update nbin * Package node-pty and spdlog with nbin * Label stderr/stdout from shared process * Remove fork override * Prevent "already disposed" errors when trying to kill disposed proxies * Include spdlog dependencies * Shim /node_modules * Add node_modules to Docker ignore It keeps using my already-built .node files which results in a mismatching GLIBC version error. * Update nbin

code-asher added 4 commits April 9, 2019 10:56

Update Node to 10.15.1

ce968b6

Remove string replace that was used for oclif

c42b63e

Update nbin

aa7956f

Package node-pty and spdlog with nbin

d0e497f

code-asher changed the title Update node Update node to 10.15.1 Apr 9, 2019

code-asher added 2 commits April 9, 2019 13:15

Label stderr/stdout from shared process

e9c0c96

Remove fork override

9de6400

code-asher force-pushed the feature/update-node branch from cde3271 to 9de6400 Compare April 9, 2019 19:34

code-asher marked this pull request as ready for review April 9, 2019 19:44

code-asher requested review from kylecarbs and nhooyr as code owners April 9, 2019 19:44

code-asher commented Apr 9, 2019

View reviewed changes

Comment thread packages/server/src/cli.ts

nhooyr suggested changes Apr 9, 2019

View reviewed changes

nhooyr reviewed Apr 9, 2019

View reviewed changes

Comment thread .node-version

code-asher force-pushed the feature/update-node branch from 7867b5e to c07a150 Compare April 9, 2019 20:27

Prevent "already disposed" errors when trying to kill disposed proxies

827dae6

code-asher force-pushed the feature/update-node branch from c07a150 to 827dae6 Compare April 9, 2019 20:28

code-asher added the wip label Apr 9, 2019

Include spdlog dependencies

b05064e

Shim /node_modules

5bc5040

code-asher commented Apr 9, 2019

View reviewed changes

Comment thread packages/server/src/cli.ts

Add node_modules to Docker ignore

8162e0f

It keeps using my already-built .node files which results in a mismatching GLIBC version error.

code-asher added the blocked This issue cannot proceed due to external factors label Apr 11, 2019

Update nbin

cc92be0

code-asher removed the blocked This issue cannot proceed due to external factors label Apr 15, 2019

code-asher removed the wip label Apr 15, 2019

kylecarbs approved these changes Apr 15, 2019

View reviewed changes

code-asher merged commit aabb2ec into master Apr 16, 2019

code-asher deleted the feature/update-node branch April 16, 2019 00:48

code-asher mentioned this pull request Apr 17, 2019

Outline not available for markdown files #406

Closed

Update node to 10.15.1 by code-asher · Pull Request #472 · coder/code-server · GitHub

Uh oh!

Update node to 10.15.1 - #472

Update node to 10.15.1#472code-asher merged 11 commits intomastercoder/code-server:masterfrom feature/update-nodecoder/code-server:feature/update-nodeCopy head branch name to clipboard

Conversation

code-asher commented Apr 9, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

nhooyr left a comment

Choose a reason for hiding this comment

Uh oh!

nhooyr commented Apr 9, 2019

Uh oh!

Uh oh!

code-asher commented Apr 9, 2019

Uh oh!

code-asher commented Apr 9, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

code-asher commented Apr 11, 2019

Uh oh!

visualphoenix commented Apr 15, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

visualphoenix commented Apr 15, 2019 via email

Uh oh!

foresthoffman commented Apr 15, 2019

Uh oh!

visualphoenix commented Apr 15, 2019 via email

Uh oh!

visualphoenix commented Apr 15, 2019 via email

Uh oh!

code-asher commented Apr 16, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Update node to 10.15.1#472
code-asher merged 11 commits into
masterfrom
feature/update-node

code-asher commented Apr 9, 2019 •
edited
Loading

code-asher commented Apr 9, 2019 •
edited
Loading

visualphoenix commented Apr 15, 2019 •
edited
Loading