FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

feat: add test for hash with empty string by jsjoeio · Pull Request #4814 · coder/code-server · GitHub

/ code-server Public

feat: add test for hash with empty string - #4814

Merged
jsjoeio merged 2 commits into
mainfrom
jsjoeio-hash-test
Feb 3, 2022
ConversationCommits (2)ChecksFiles changed
Merged

feat: add test for hash with empty string#4814
jsjoeio merged 2 commits into
mainfrom
jsjoeio-hash-test

Conversation

jsjoeio commented Jan 31, 2022 •
edited
Loading

Copy link
Copy Markdown
Contributor

This PR adds an additional test for the hash function.

Fixes N/A

#TestingMondays

jsjoeio added the testing Anything related to testing label Jan 31, 2022
jsjoeio added this to the 4.0.3 milestone Jan 31, 2022
jsjoeio self-assigned this Jan 31, 2022
jsjoeio requested a review from a team January 31, 2022 23:12
jsjoeio temporarily deployed to CI January 31, 2022 23:12 Inactive

github-actions Bot commented Jan 31, 2022 •
edited
Loading

Copy link
Copy Markdown

✨ Coder.com for PR #4814 deployed! It will be updated on every commit.

codecov Bot commented Jan 31, 2022 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

❗ No coverage uploaded for pull request base (main@fd643dc). Click here to learn what that means.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #4814   +/-   ##
=======================================
  Coverage        ?   69.25%           
=======================================
  Files           ?       29           
  Lines           ?     1649           
  Branches        ?      363           
=======================================
  Hits            ?     1142           
  Misses          ?      430           
  Partials        ?       77
Impacted Files Coverage Δ
src/node/util.ts 82.06% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fd643dc...6db1ac2. Read the comment docs.

code-asher reviewed Feb 1, 2022
View reviewed changes
Comment thread test/unit/node/util.test.ts Outdated
jsjoeio temporarily deployed to CI February 3, 2022 19:53 Inactive
jsjoeio changed the title feat: add test for hash when error feat: add test for hash with empty string Feb 3, 2022
jsjoeio commented Feb 3, 2022
View reviewed changes
Comment thread src/node/util.ts
Comment on lines -160 to -165
try {
return await argon2.hash(password)
} catch (error: any) {
logger.error(error)
return ""
}

jsjoeio Feb 3, 2022

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

✍🏼 as discussed with @code-asher, this will only throw if you throw in something other than string (like number). Since TS will prevent that, we don't need the try/catch block.

jsjoeio requested a review from code-asher February 3, 2022 20:54
jsjoeio temporarily deployed to CI February 3, 2022 20:54 Inactive
code-asher approved these changes Feb 3, 2022
View reviewed changes

code-asher left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

🎉

jsjoeio merged commit 00224fa into main Feb 3, 2022
jsjoeio deleted the jsjoeio-hash-test branch February 3, 2022 21:22
TinLe pushed a commit to TinLe/code-server that referenced this pull request Apr 23, 2022
feat: add test for hash when error (coder#4814)
22a79cb
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

code-asher code-asher approved these changes

Assignees

jsjoeio

Labels

testing Anything related to testing

Projects

None yet

Milestone

4.1.0

Development

Successfully merging this pull request may close these issues.

2 participants

Back | FazBrowse Home | New Git URL