✨ Coder.com for PR #4902 deployed! It will be updated on every commit.

• Host: https://codercom-old-ahoyq6qu7-codercom.vercel.app/docs/code-server
• Last deploy status: success
• Commit: ed44bbc
• Workflow status: https://github.com/coder/code-server/actions/runs/1959662879

Codecov Report

Merging #4902 (ed44bbc) into main (3b93a86) will increase coverage by 0.01%.
The diff coverage is 85.71%.

@@            Coverage Diff             @@
##             main    #4902      +/-   ##
==========================================
+ Coverage   70.54%   70.56%   +0.01%     
==========================================
  Files          29       29              
  Lines        1677     1678       +1     
  Branches      371      372       +1     
==========================================
+ Hits         1183     1184       +1     
  Misses        420      420              
  Partials       74       74              

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3b93a86...ed44bbc. Read the comment docs.

Looks like the E2E tests are failing due to a missing dependency:

[2022-03-05T00:[19](https://github.com/coder/code-server/runs/5429719980?check_suite_focus=true#step:9:19):40.752Z] warn  Cannot find module '../../vendor/modules/code-oss-dev/package.json'
Require stack:
- /home/runner/work/code-server/code-server/src/node/constants.ts
- /home/runner/work/code-server/code-server/src/node/util.ts
- /home/runner/work/code-server/code-server/test/utils/globalE2eSetup.ts
- /home/runner/work/code-server/code-server/test/node_modules/@playwright/test/lib/loader.js
- /home/runner/work/code-server/code-server/test/node_modules/@playwright/test/lib/cli.js
- /home/runner/work/code-server/code-server/test/node_modules/playwright-core/lib/cli/cli.js
- /home/runner/work/code-server/code-server/test/node_modules/playwright-core/cli.js
- /home/runner/work/code-server/code-server/test/node_modules/playwright/cli.js

[2022-03-08T00:24:17.340Z] warn Cannot find module '/home/runner/work/code-server/code-server/vendor/modules/code-oss-dev/package.json'
Require stack:

Argh still failing. Might need your help looking at this again @code-asher

How to reproduce locally

We know that we can reproduce this issue Cannot find module '../../vendor/modules/code-oss-dev/package.json' locally by deleting the vendor/modules/code-oss-dev/package.json.

Root cause

We thought it was the package.json not getting included when using the vscode cache in CI so we added it here:

So either that's not it or it didn't rebuild vscode even though we changed the cache key.

Looks like that didn't work. So we'll need to either temporarily disable cache or figure out something else.

EDIT: I confused the cache key with the job id. Newest commit should fix it. Trying this solution too