FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

feat: cli arg for file permission of socket by TechCiel · Pull Request #4923 · coder/code-server · GitHub

  1. coder
  2. code-server

Repository navigation

feat: cli arg for file permission of socket - #4923

Merged
jsjoeio merged 1 commit into
coder:mainfrom
TechCiel:main
Mar 3, 2022
ConversationCommits (1)ChecksFiles changed
Merged

feat: cli arg for file permission of socket#4923
jsjoeio merged 1 commit into
coder:mainfrom
TechCiel:main

Conversation

TechCiel commented Feb 28, 2022

Copy link
Copy Markdown
Contributor

Fixes #1466

Add a cli option --socket-permission, and set file mode accordingly when listening a socket.

TechCiel requested a review from a team February 28, 2022 14:07
jsjoeio self-assigned this Feb 28, 2022
jsjoeio approved these changes Feb 28, 2022
View reviewed changes

jsjoeio left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Very clean PR 👏 Thank you for adding tests as well!

I'm less familiar with socket-permissions so I'll defer review to @code-asher

jsjoeio added the feature New user visible feature label Mar 1, 2022

codecov Bot commented Mar 1, 2022 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #4923 (c1abea9) into main (78658f1) will increase coverage by 0.00%.
The diff coverage is 66.66%.

@@           Coverage Diff           @@
##             main    #4923   +/-   ##
=======================================
  Coverage   70.29%   70.30%           
=======================================
  Files          29       29           
  Lines        1670     1677    +7     
  Branches      369      371    +2     
=======================================
+ Hits         1174     1179    +5     
- Misses        422      424    +2     
  Partials       74       74
Impacted Files Coverage Δ
src/node/app.ts 94.82% <62.50%> (-3.25%) ⬇️
src/node/cli.ts 84.35% <100.00%> (+0.05%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 78658f1...c1abea9. Read the comment docs.

jsjoeio assigned code-asher and unassigned jsjoeio Mar 1, 2022
code-asher requested changes Mar 2, 2022
View reviewed changes

code-asher left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Thank you for the contribution! This has been a long-standing one.

Comment thread src/node/app.ts Outdated
Comment thread src/node/app.ts Outdated
TechCiel requested a review from code-asher March 3, 2022 09:28
jsjoeio added this to the 4.0.3 milestone Mar 3, 2022
jsjoeio merged commit c4d8758 into coder:main Mar 3, 2022
TinLe pushed a commit to TinLe/code-server that referenced this pull request Apr 23, 2022
feat: cli arg for file permission of socket (coder#4923)
4bfa9f8
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

code-asher code-asher approved these changes
+1 more reviewer
jsjoeio jsjoeio approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

code-asher

Labels

feature New user visible feature

Projects

None yet

Milestone

4.1.0

Development

Successfully merging this pull request may close these issues.

Add option to set unix socket permissions

3 participants

Back | FazBrowse Home | New Git URL