FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

fix: Exclude .deb files from release Docker image by dwahler · Pull Request #5068 · coder/code-server · GitHub

/ code-server Public

fix: Exclude .deb files from release Docker image - #5068

Merged
jsjoeio merged 1 commit into
coder:mainfrom
dwahler:docker-shrink
Apr 6, 2022
ConversationCommits (1)ChecksFiles changed
Merged

fix: Exclude .deb files from release Docker image#5068
jsjoeio merged 1 commit into
coder:mainfrom
dwahler:docker-shrink

Conversation

dwahler commented Apr 5, 2022

Copy link
Copy Markdown
Contributor

Currently, the codercom/code-server Docker image includes a copy of the release's .deb package files, even though they're only used in an intermediate layer. What's more, it includes packages from every architecture, not just the one being released.

This patch fixes this by updating the Dockerfile to use a multi-stage build. First, the packages are copied from the local build context into a temporary directory in a "scratch" build stage. Then, this directory is mounted into the main build, so that the appropriate .deb file can be installed without ever being actually stored in the image.

In my testing (with the 4.2.0 packages for linux-amd64) this reduces the total compressed and uncompressed size by a fairly substantial amount:

Before After Change
compressed 637 MB 268 MB -58%
uncompressed 1094 MB 724 MB -34%

Partially fixes #4112

dwahler requested a review from a team April 5, 2022 23:05
dwahler mentioned this pull request Apr 5, 2022
Closed

dwahler commented Apr 6, 2022

Copy link
Copy Markdown
Contributor Author

I guess the "semantic pull request" check is failing because it wants a prefix on the PR title, but I'm not sure what would be most appropriate. It's not really a "feature", so maybe "perf"?

code-asher commented Apr 6, 2022

Copy link
Copy Markdown
Member

Good question. perf seems good to me although we do not have that as an option so we would need to add it.

code-server/.github/semantic.yaml

Lines 37 to 66 in 5bc26e9

types:
# A build of any kind.
- build
# A user-facing change that corrects a defect in code-server.
- fix
# Any code task that is ignored for changelog purposes. Examples include
# devbin scripts and internal-only configurations.
- chore
# Any work performed on CI.
- ci
# Work that directly implements or supports the implementation of a feature.
- feat
# A refactor changes code structure without any behavioral change.
- refactor
# A git revert for any style of commit.
- revert
# Adding tests of any kind. Should be separate from feature or fix
# implementations. For example, if a commit adds a fix + test, it's a fix
# commit. If a commit is simply bumping coverage, it's a test commit.
- test
# A new release.
- release

code-asher approved these changes Apr 6, 2022
View reviewed changes

code-asher left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Those are some excellent savings. The multi-stage build is clever! Thanks for the improvement!

codecov Bot commented Apr 6, 2022

Copy link
Copy Markdown

Codecov Report

Merging #5068 (63d0128) into main (5bc26e9) will not change coverage.
The diff coverage is n/a.

❗ Current head 63d0128 differs from pull request most recent head 163938d. Consider uploading reports for the commit 163938d to get more accurate results

@@           Coverage Diff           @@
##             main    #5068   +/-   ##
=======================================
  Coverage   71.30%   71.30%           
=======================================
  Files          30       30           
  Lines        1683     1683           
  Branches      373      373           
=======================================
  Hits         1200     1200           
  Misses        413      413           
  Partials       70       70

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5bc26e9...163938d. Read the comment docs.

jsjoeio added enhancement Some improvement that isn't a feature chore Related to maintenance or clean up labels Apr 6, 2022
jsjoeio added this to the April 2022 milestone Apr 6, 2022

jsjoeio commented Apr 6, 2022

Copy link
Copy Markdown
Contributor

Echoing Asher, those are some huge improvements. Thank you so much for doing this!

jsjoeio changed the title Exclude .deb files from release Docker image fix: Exclude .deb files from release Docker image Apr 6, 2022
jsjoeio merged commit 38e57a3 into coder:main Apr 6, 2022
jsjoeio modified the milestones: April 2022, 4.3.0 Apr 13, 2022
TinLe pushed a commit to TinLe/code-server that referenced this pull request Apr 23, 2022
Exclude .deb files from release Docker image (coder#5068)
a57161f
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

code-asher code-asher approved these changes

Assignees

No one assigned

Labels

chore Related to maintenance or clean up enhancement Some improvement that isn't a feature

Projects

None yet

Milestone

4.3.0

Development

Successfully merging this pull request may close these issues.

Smaller docker image for production?

3 participants

Back | FazBrowse Home | New Git URL