FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

chore: add npm followup comment by jsjoeio · Pull Request #5541 · coder/code-server · GitHub

Repository navigation

chore: add npm followup comment - #5541

Merged
jsjoeio merged 2 commits into
mainfrom
jsjoeio/npm-fixups
Sep 6, 2022
Merged

jsjoeio merged 2 commits into
mainfrom
jsjoeio/npm-fixups

Conversation

jsjoeio commented Sep 6, 2022 •
edited
Loading

Copy link
Copy Markdown
Contributor
  • chore: use npm ci in build-standalone-release
  • docs: add comment to npm-postinstall.sh

followup from #5533

jsjoeio requested a review from a team as a code owner September 6, 2022 18:51
jsjoeio self-assigned this Sep 6, 2022

jsjoeio commented Sep 6, 2022

Copy link
Copy Markdown
Contributor Author

cc @edvincent

jsjoeio added this to the September 2022 milestone Sep 6, 2022
jsjoeio added chore Related to maintenance or clean up rebase when passing labels Sep 6, 2022
jsjoeio temporarily deployed to npm September 6, 2022 18:57 Inactive

github-actions Bot commented Sep 6, 2022 •
edited
Loading

Copy link
Copy Markdown

✨ code-server dev build published to npm for PR #5541!

  • Last publish status: success
  • Commit: 9b889f4

To install in a local project, run:

npm install @coder/code-server-pr@5541

To install globally, run:

npm install -g @coder/code-server-pr@5541

codecov Bot commented Sep 6, 2022 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #5541 (175fa0e) into main (da03a64) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #5541   +/-   ##
=======================================
  Coverage   72.44%   72.44%           
=======================================
  Files          30       30           
  Lines        1673     1673           
  Branches      366      366           
=======================================
  Hits         1212     1212           
  Misses        398      398           
  Partials       63       63           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update da03a64...175fa0e. Read the comment docs.

Copy link
Copy Markdown
Contributor

Yeah... npm ci still needs some looking around... Which is why I was suggesting to follow-up on this as I have already gathered some knowledge around npm these last couple of months 😂

jsjoeio commented Sep 6, 2022

Copy link
Copy Markdown
Contributor Author

Yeah... npm ci still needs some looking around... Which is why I was suggesting to follow-up on this as I have already gathered some knowledge around npm these last couple of months 😂

LOL darn it! Why can't anything ever be easy... okay let me drop the npm ci commit and at least add that comment.

jsjoeio changed the title jsjoeio/npm fixups chore: add npm followup comment Sep 6, 2022
jsjoeio temporarily deployed to npm September 6, 2022 20:13 Inactive
jsjoeio merged commit 64822d0 into main Sep 6, 2022
jsjoeio deleted the jsjoeio/npm-fixups branch September 6, 2022 20:34
jsjoeio temporarily deployed to npm September 6, 2022 20:39 Inactive
jsjoeio modified the milestones: September 2022, v4.7.0 Sep 9, 2022

This branch was previously deployed

1 inactive deployment
npm — 9b889f4f Deployed Sep 6, 2022 by jsjoeio
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

chore Related to maintenance or clean up

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants


Back | FazBrowse Home | New Git URL