FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

add trusted-origins cli argument by alexthillen · Pull Request #6319 · coder/code-server · GitHub

Repository navigation

add trusted-origins cli argument - #6319

Merged
code-asher merged 5 commits into
coder:mainfrom
alexthillen:main
Jul 19, 2023
Merged

code-asher merged 5 commits into
coder:mainfrom
alexthillen:main

Conversation

Copy link
Copy Markdown
Contributor

Fixes #6064

alexthillen requested a review from a team as a code owner July 10, 2023 12:36

code-asher commented Jul 10, 2023 •
edited
Loading

Copy link
Copy Markdown
Member

Thanks for the patch! Could we add a --trusted-proxy flag instead? Then if someone is dealing with a misconfigured proxy that cannot be fixed they can use --trusted-proxy 127.0.0.1 or whatever address their proxy is giving them.

Copy link
Copy Markdown
Member

Or maybe --trusted-origin could be better, not sure.

Copy link
Copy Markdown
Contributor Author

Thanks for getting back to me. Added --trusted-origins flag instead.

alexthillen changed the title add disable-authenticate-origin flag add trusted-origins cli argument Jul 11, 2023

code-asher left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Thanks, this is great! The * is a nice touch too.

Copy link
Copy Markdown
Member

Ah right we will need to update the unit test as well.

Copy link
Copy Markdown
Contributor Author

Thanks for the feedback!
Updated the unit tests accordingly. They are passing now.

alexthillen requested a review from code-asher July 19, 2023 07:15

codecov Bot commented Jul 19, 2023

Copy link
Copy Markdown

Codecov Report

Merging #6319 (5cfc0e3) into main (5c19962) will decrease coverage by 0.02%.
The diff coverage is 66.66%.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #6319      +/-   ##
==========================================
- Coverage   73.67%   73.66%   -0.02%     
==========================================
  Files          31       31              
  Lines        1869     1872       +3     
  Branches      401      403       +2     
==========================================
+ Hits         1377     1379       +2     
- Misses        415      416       +1     
  Partials       77       77              
Impacted Files Coverage Δ
src/node/cli.ts 90.80% <ø> (ø)
src/node/http.ts 70.71% <66.66%> (-0.09%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 070a5a3...5cfc0e3. Read the comment docs.

code-asher merged commit 93e60f7 into coder:main Jul 19, 2023

Copy link
Copy Markdown
Member

Thanks again!

yiliang114 pushed a commit to yiliang114/code-server that referenced this pull request Jan 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: error Forbidden HttpError: Forbidden

2 participants


Back | FazBrowse Home | New Git URL