FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

#914 - New helm chart for v1 by paolomainardi · Pull Request #917 · coder/code-server · GitHub

/ code-server Public

#914 - New helm chart for v1 - #917

Merged
deansheather merged 2 commits into
coder:masterfrom
paolomainardi:master
Aug 20, 2019
ConversationCommits (2)ChecksFiles changed
Merged

#914 - New helm chart for v1#917
deansheather merged 2 commits into
coder:masterfrom
paolomainardi:master

Conversation

paolomainardi commented Aug 18, 2019 •
edited
Loading

Copy link
Copy Markdown
Contributor

Refs to #914

This PR adds an helm chart as another deployment option for Kubernetes.

I've made 1 opinionated decision for the persistence storage, by keeping persistent /home/coder/project and /home/coder/.local/share/code-server directory which basically contains all the vscode configurations, such as extensions, settings etc.

The helm chart includes an extensive README that should cover all the aspects to install and configure code-server.

The helm chart is now compatible with the latest stable version, but once the v2 will be out, the helm chart can be updated accordingly (it's just a matter of changing the port for now).

It still misses:

  • Define runtime variables from helm chart
  • Generate a k8s secret for PASSWORD
  • Make the args configurable

paolomainardi changed the title refs #914: New helm chart for v1 #914 New helm chart for v1 Aug 18, 2019
paolomainardi changed the title #914 New helm chart for v1 #914 - New helm chart for v1 Aug 18, 2019
paolomainardi changed the title #914 - New helm chart for v1 WIP - #914 - New helm chart for v1 Aug 18, 2019
paolomainardi changed the title WIP - #914 - New helm chart for v1 #914 - New helm chart for v1 Aug 18, 2019
deansheather approved these changes Aug 19, 2019
View reviewed changes

deansheather left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Seems pretty comprehensive. Persisting the ~/.local/share/code-server directory seems fine to me.

Comment thread deployment/chart/README.md
sr229 suggested changes Aug 19, 2019
View reviewed changes
Comment thread deployment/chart/templates/deployment.yaml
Comment thread deployment/chart/values.yaml Outdated
Comment thread deployment/chart/templates/pvc.yaml
Comment thread deployment/chart/templates/deployment.yaml
sr229 approved these changes Aug 19, 2019
View reviewed changes

sr229 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I can LGTM this since my suggestions were applied and OP seems to defend their config decisions adequately.

deansheather commented Aug 19, 2019

Copy link
Copy Markdown
Member

Blocked on PGP signatures. I can merge this once you've signed all of your commits! 🔑

paolomainardi commented Aug 19, 2019

Copy link
Copy Markdown
Contributor Author

@deansheather signed and squashed 👍

deansheather merged commit 0f1bbc3 into coder:master Aug 20, 2019

deansheather commented Aug 20, 2019

Copy link
Copy Markdown
Member

Thanks for contributing this!

paolomainardi commented Aug 20, 2019

Copy link
Copy Markdown
Contributor Author

Thanks for merging!

Matthew-Beckett mentioned this pull request Sep 7, 2020
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

deansheather deansheather approved these changes
code-asher Awaiting requested review from code-asher
kylecarbs Awaiting requested review from kylecarbs
+1 more reviewer
sr229 sr229 approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL