FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

fix(site): scroll per-script logs selector on overflow by jakehwll · Pull Request #28353 · coder/coder · GitHub

/ coder Public

fix(site): scroll per-script logs selector on overflow - #28353

Merged
jakehwll merged 1 commit into
mainfrom
jakehwll/devex-721-logs-selector-scroll-on-overflow
Aug 20, 2026
Merged

fix(site): scroll per-script logs selector on overflow#28353
jakehwll merged 1 commit into
mainfrom
jakehwll/devex-721-logs-selector-scroll-on-overflow

Conversation

jakehwll commented Aug 20, 2026
edited
Loading

Copy link
Copy Markdown
Contributor

🤖 This PR was written by Coder Agents on behalf of Jake Howell.

Resolves DEVEX-721.

Cap the overflow menu height and let it scroll, matching the existing pattern already used by DownloadSelectedAgentLogsButton (max-h-56 overflow-y-auto). No component swap needed, the DropdownMenu was the right primitive, it just lacked height/scroll constraints.

-<DropdownMenuContent align="end">
+<DropdownMenuContent align="end" className="max-h-56 overflow-y-auto">
Investigation / decision log
  • The "logs selector per startup script" is the overflow kebab menu in site/src/modules/resources/AgentRow.tsx. When per-script log tabs don't fit horizontally, useKebabMenu moves the extras into a Radix DropdownMenu rendered as DropdownMenuRadioItems.
  • menuContentClass (site/src/components/DropdownMenu/menuClasses.ts) is z-50 min-w-48 overflow-hidden ... with no max-height, so an overlong menu is clipped instead of scrolling.
  • DownloadSelectedAgentLogsButton.tsx already solves the identical problem on its own menu with className="max-h-56 overflow-y-auto", so we reused that for consistency.
  • Considered switching to the Select component (which has SelectScrollUpButton/SelectScrollDownButton chevrons) but that's a larger re-model of the trigger + items and reconciliation with the Tabs/useKebabMenu wiring. Deferred in favor of the minimal fix.

linear-code Bot commented Aug 20, 2026

Copy link
Copy Markdown

DEVEX-721

jakehwll requested a review from jeremyruppel August 20, 2026 06:47
jakehwll marked this pull request as ready for review August 20, 2026 06:48

chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 88444dc614

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

jakehwll changed the title 🤖 fix(site/src/modules/resources): scroll per-script logs selector on overflow 🤖 fix(site): scroll per-script logs selector on overflow Aug 20, 2026
jakehwll changed the title 🤖 fix(site): scroll per-script logs selector on overflow fix(site): scroll per-script logs selector on overflow Aug 20, 2026
jakehwll merged commit 05b78a0 into main Aug 20, 2026
61 of 66 checks passed
jakehwll deleted the jakehwll/devex-721-logs-selector-scroll-on-overflow branch August 20, 2026 15:22
github-actions Bot locked and limited conversation to collaborators Aug 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants


Back | FazBrowse Home | New Git URL