fix(site): stop back link overlapping the new workspace form - #28355
Draft
jakehwll wants to merge 3 commits into
Draft
fix(site): stop back link overlapping the new workspace form#28355jakehwll wants to merge 3 commits into
jakehwll wants to merge 3 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Reuse the create-organization page grid (1fr / centered content / 1fr) so the back link sits in its own column instead of overlapping the header. Rename the ambiguous "Go back" to "Back to workspaces" and point it at the workspaces list so the label matches the action.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The new workspace page's back link was absolutely positioned (sticky + translate-y-[68px]) and overlapped the header/template title.
This reuses the grid layout landed in #27914 for the create organization page — grid-cols-[1fr_minmax(0,800px)_1fr] — so the back link lives in its own column beside the centered form instead of on top of it.
Changes
- CreateWorkspacePageView.tsx: wrap the page in the shared three-column grid and replace the custom sticky <button> with the standard Button variant="subtle". Behaviour is unchanged — still ← Go back calling onCancel (navigate(-1)).
Notes for reviewers