FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

GitBash and MinGW support by Merith-TK · Pull Request #132 · coder/sshcode · GitHub

This repository was archived by the owner on Jan 17, 2021. It is now read-only.
  1. coder
  2. sshcode

Repository navigation

GitBash and MinGW support - #132

Closed
Merith-TK wants to merge 30 commits into
coder:masterfrom
Merith-TK:msys-support
ConversationCommits (30)ChecksFiles changed
Closed

GitBash and MinGW support#132
Merith-TK wants to merge 30 commits into
coder:masterfrom
Merith-TK:msys-support

Conversation

Merith-TK commented Aug 15, 2019 •
edited
Loading

Copy link
Copy Markdown
Contributor

TL;DR

Summary of Edits

  • Fixed file pathing for windows client
  • Fixed ghost path creation on windows client
  • Added check to fix variables when using windows clients

Progress

Latest Build:

  • Resolving paths is now fully functional.
  • Ghost paths are no longer created on the client, (bug with patches to ensureDir()
  • The following formats now work for opening remote paths, /Workspace, Workspace, ~/Workspace, Workspace/
  • Code cleanup

deansheather suggested changes Aug 15, 2019
View reviewed changes
Comment thread main.go Outdated
Comment thread main.go Outdated
Comment thread .gitignore Outdated
Comment thread main.go Outdated
Comment thread sshcode.go Outdated

deansheather commented Sep 17, 2019

Copy link
Copy Markdown
Collaborator

Is this still being worked on? The hardcoded C:\mingw64 thing is still an issue. Would like to merge this soon.

Meanwhile, sshcode seems to work on WSL now other than a few small hiccups.

Merith-TK commented Sep 17, 2019 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

It is being worked on, i am slowly working on a home detector, see https://github.com/Merith-TK/Personal-Projects/blob/master/Home.go

Also school started a few weeks ago and i have been basically swamped. and i cant even test it at school during lunch because they blocked ssh... for some stupid reason

MOST RECENT PUSH FIXED THE ISSUE

Merith-TK mentioned this pull request Oct 9, 2019
Open
Merith-TK mentioned this pull request Nov 2, 2019
Open
deansheather suggested changes Nov 19, 2019
View reviewed changes
Comment thread main.go Outdated
Comment thread sshcode.go
Comment thread main.go Outdated
Comment thread main.go Outdated
Comment thread settings.go Outdated
Comment thread sshcode.go Outdated
Comment thread sshcode.go Outdated
Comment thread main.go
Comment thread main.go Outdated
Comment thread main.go
deansheather reviewed Nov 21, 2019
View reviewed changes
Comment thread main.go Outdated
deansheather approved these changes Dec 16, 2019
View reviewed changes
Comment thread sshcode.go

deansheather commented Mar 13, 2020

Copy link
Copy Markdown
Collaborator

In that case we should just add a section to the README which says what env variable to use depending on git bash or msys.

Merith-TK commented Apr 8, 2020 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

I still don't want to rewrite the entire path fixing function but I am working on it since the F***ing coronavirus has canceled my plans.
https://cdn.merith.tk/workspace/merith/go-sshcode/sshcode.go
2020-04-07 20:22:10 INFO Resolved windows path 'C:/msys64/Workspace' to '/msys64/Workspace
is where I am at at the moment,
What would be helpful is a command like winpath in wsl. because that thing you feed it a unix path, it will give the windows equivilant

EDIT, i am running sshcode.exe developer@192.168.0.115 --skipsync /Workspace

EDIT2: I am ready to throw my computer out the window
{ cd / && pwd -W; } | sed 's|/|\\|g' returns C:\Program Files\Git on gitbash
and C:\msys64\ on msys

Merith-TK commented Apr 8, 2020

Copy link
Copy Markdown
Contributor Author

one second, need to undo a personal modification

Merith-TK commented Apr 8, 2020

Copy link
Copy Markdown
Contributor Author

Don't know whats going on with the current Travis build for you guys, but the build for me is working...
https://travis-ci.org/github/Merith-TK/sshcode

deansheather reviewed Apr 8, 2020
View reviewed changes
Comment thread sshcode.go
Comment thread sshcode.go Outdated
Comment thread sshcode.go Outdated
Comment thread sshcode.go Outdated
Comment thread sshcode.go Outdated
Comment thread sshcode.go Outdated
Comment thread sshcode.go Outdated

kylejbrk commented Apr 10, 2020

Copy link
Copy Markdown

Any updates on this? Looking forward if this can run via Gitbash/Windows.

Merith-TK commented Apr 10, 2020

Copy link
Copy Markdown
Contributor Author

@kylejbrk

Any updates on this? Looking forward if this can run via Gitbash/Windows.

My fork is completely functional for gitbash, msys2, and mingw.
waiting on it to be merged

You can clone my repo in its current state and build it yourself if you like

Merith-TK commented Apr 18, 2020

Copy link
Copy Markdown
Contributor Author

Dont know what broke travis for you guys, but it passes on my end
https://travis-ci.org/github/Merith-TK/sshcode

deansheather reviewed Apr 18, 2020
View reviewed changes

deansheather left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Some of my earlier reviews haven't been fixed properly.

deansheather commented Apr 18, 2020

Copy link
Copy Markdown
Collaborator

Please re-request a review when you want this to be reviewed and merged. I don't read most of my github emails because I get too many, but I get a notification on slack if I'm requested for review.

Merith-TK requested a review from deansheather April 18, 2020 18:42
deansheather reviewed Apr 18, 2020
View reviewed changes
Comment thread sshcode.go Outdated
Comment thread sshcode.go
Comment thread main.go
Merith-TK requested a review from deansheather April 20, 2020 20:03

deansheather commented Apr 20, 2020

Copy link
Copy Markdown
Collaborator

I can't merge this automatically because of glitch with travis. The build passed on travis but didn't get reported to github. I'll squash and merge this manually tomorrow.

Merith-TK commented Apr 21, 2020

Copy link
Copy Markdown
Contributor Author

Alright, hope people find this useful!

deansheather added a commit that referenced this pull request Apr 27, 2020
Add git bash and mingw support (#132)
50e859c 
Supports git bash and mingw on Windows. Does not support cmd.exe.

Signed-off-by: Dean Sheather <dean@deansheather.com>
Co-authored-by: Merith <merith.tk@gmail.com>

deansheather commented Apr 27, 2020

Copy link
Copy Markdown
Collaborator

Squashed and merged via 50e859c

Merith-TK deleted the msys-support branch May 2, 2020 22:51
Merith-TK restored the msys-support branch May 2, 2020 22:52
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers
IngCr3at1on IngCr3at1on left review comments
deansheather deansheather approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

Back | FazBrowse Home | New Git URL