FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Add a simple bash test by sreya · Pull Request #61 · coder/sshcode · GitHub

This repository was archived by the owner on Jan 17, 2021. It is now read-only.
  1. coder
  2. sshcode

Repository navigation

Add a simple bash test - #61

Merged
sreya merged 1 commit into
masterfrom
test
Apr 30, 2019
ConversationCommits (1)ChecksFiles changed
Merged

Add a simple bash test#61
sreya merged 1 commit into
masterfrom
test

Conversation

sreya commented Apr 24, 2019

Copy link
Copy Markdown
Collaborator

No description provided.

sreya requested review from ammario, kylecarbs and nhooyr April 24, 2019 18:54
nhooyr suggested changes Apr 24, 2019
View reviewed changes

nhooyr left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Why not have a more automated test for this?

You can start up a SSH server with crypto/ssh and that runs the given commands locally and then confirm code-server is up and running and then kill it.

Comment thread main.go Outdated
syncBack = flag.Bool("b", false, "sync extensions back on termination")
printVersion = flag.Bool("version", false, "print version information and exit")
port = flag.String("port", "", "Start VS Code on the provided port. If one is not provided a random one is selected")
noOpen = flag.Bool("no-open", false, "Start VS Code but don't open a Chrome app window")

nhooyr Apr 24, 2019

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

lets use $DISPLAY = "" for this

ammario Apr 25, 2019

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Is DISPLAY set on all macs?

nhooyr Apr 25, 2019

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Yes, similar to how there is an X11 socket whose path is given by $DISPLAY, $DISPLAY on macOS contains the quartz socket.

ammario Apr 25, 2019

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

What about WSL?

nhooyr Apr 25, 2019

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

WSL is almost certainly using some sort of X11 forwarding so it would have $DISPLAY.

ammario reviewed Apr 25, 2019
View reviewed changes
Comment thread main.go Outdated
syncBack = flag.Bool("b", false, "sync extensions back on termination")
printVersion = flag.Bool("version", false, "print version information and exit")
port = flag.String("port", "", "Start VS Code on the provided port. If one is not provided a random one is selected")
noOpen = flag.Bool("no-open", false, "Start VS Code but don't open a Chrome app window")

ammario Apr 25, 2019

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Is DISPLAY set on all macs?

Comment thread test.sh Outdated
sreya requested review from ammario and nhooyr April 26, 2019 22:47
scsmithr reviewed Apr 26, 2019
View reviewed changes
Comment thread sshcode_test.go
nhooyr suggested changes Apr 29, 2019
View reviewed changes

nhooyr left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

looks solid otherwise 🚀

Comment thread main.go Outdated
Comment thread main.go Outdated
Comment thread sshcode_test.go Outdated
sreya mentioned this pull request Apr 29, 2019
Closed
sreya force-pushed the test branch 3 times, most recently from 72f6d59 to 439b37f Compare April 29, 2019 21:57
sreya merged commit 050d775 into master Apr 30, 2019
sreya deleted the test branch April 30, 2019 00:49
sreya mentioned this pull request Apr 30, 2019
Closed
sreya added a commit that referenced this pull request Apr 30, 2019
Merge pull request #61 from cdr/test
eed7106 
Add a sanity test

- Refactor and break out code from main()
- Use a random remote port
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

kylecarbs Awaiting requested review from kylecarbs
ammario Awaiting requested review from ammario
2 more reviewers
scsmithr scsmithr left review comments
nhooyr nhooyr requested changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

Back | FazBrowse Home | New Git URL