FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Some updates for document by tokikanno · Pull Request #89 · coder/sshcode · GitHub

This repository was archived by the owner on Jan 17, 2021. It is now read-only.

Repository navigation

Some updates for document - #89

Merged
sreya merged 4 commits into
coder:masterfrom
tokikanno:master
May 6, 2019
Merged

sreya merged 4 commits into
coder:masterfrom
tokikanno:master

Conversation

Copy link
Copy Markdown
Contributor
  1. remote directory parameter MUST be quoted on some OS (like MacOS)
  2. OS has no X-window installed (like MacOS) need to set a fake DISPLAY env variable for enabling the auto open in browser feature.

tokikanno added 2 commits May 3, 2019 12:07
For OS has no X-Window installed(e.g.: MacOS), you need to set a fake
DISPLAY env for the auto open in browser function working.
tokikanno changed the title Some update for document Some updates for document May 3, 2019

sreya left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Hi thanks for these doc updates! I had some very minor comments on the verbiage but once they are addressed I'll merge this in. Thanks again!

Comment thread README.md

```bash
sshcode kyle@dev.kwc.io ~/projects/sourcegraph
sshcode kyle@dev.kwc.io "~/projects/sourcegraph"

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

This needs to be quoted on all OSes, thank you.

Comment thread README.md Outdated
sreya merged commit 46ef157 into coder:master May 6, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants


Back | FazBrowse Home | New Git URL