Add "Sign in with Apple" support - #49
Open
erral wants to merge 19 commits into
Open
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
|
@ericof can you help me with the dependencies check? I have introduced PyJWT as a dependency but the checker says I am missing the jwt dependency. The point is that when installing PyJWT you have to do import jwt. Yes. I know. One more in the wonderful python packaging problem (and this is better than djangorestframework-jwt). I tried adding it to .meta.toml as suggested in the pyproject.toml but I don't get how to do the mapping between them, |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As explained in #46 ...
Sign in with Apple is an OpenID Connectish interface to allow users sign in using their Apple credentials.
It has some peculiarities like:
I am not sure whether introducing Apple weirdness in this plugin is OK, but as it mostly complies with OIDC I have added a PR. And also because I am running in on a small production site.
I am open to discuss it.