FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

chore: remove dead code _find_check by shenxianpeng · Pull Request #484 · commit-check/commit-check · GitHub

/ commit-check Public

chore: remove dead code _find_check - #484

Merged
shenxianpeng merged 1 commit into
mainfrom
chore/remove-dead-code-find-check
Jul 29, 2026
ConversationCommits (1)ChecksFiles changed
Merged

chore: remove dead code _find_check#484
shenxianpeng merged 1 commit into
mainfrom
chore/remove-dead-code-find-check

Conversation

shenxianpeng commented Jul 29, 2026

Copy link
Copy Markdown
Member

Summary

_find_check in commit_check/util.py is no longer referenced by any production code. Only its tests in tests/util_test.py still called it — this is dead code.

Changes

  • commit_check/util.py: Removed the _find_check function definition (11 lines)
  • tests/util_test.py: Removed the _find_check import and the entire TestHelperFunctions test class (3 test methods)

Verification

  • grep -rn "_find_check" confirms zero references outside of the deleted lines
  • ruff check / ruff format / mypy all pass
  • All 434 tests pass (python3 -m pytest -x -q)

chore: remove dead code _find_check
656e658 
_find_check in commit_check/util.py was no longer used by any
production code. Only its tests in tests/util_test.py referenced it.
Remove both the function and its corresponding test class.
shenxianpeng requested a review from a team as a code owner July 29, 2026 20:30

netlify Bot commented Jul 29, 2026 •
edited
Loading

Copy link
Copy Markdown

✅ Deploy Preview for commit-check ready!

Name Link
🔨 Latest commit 656e658
🔍 Latest deploy log https://app.netlify.com/projects/commit-check/deploys/6a6a62e678858b0008b5b756
😎 Deploy Preview https://deploy-preview-484--commit-check.netlify.app
📱 Preview on mobile Toggle QR Code...



Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

coderabbitai Bot commented Jul 29, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

@shenxianpeng, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 45 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details ⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 29697886-c5b0-44cc-9253-ed83340e0f3f

📥 Commits

Reviewing files that changed from the base of the PR and between ad606e1 and 656e658.

📒 Files selected for processing (2)
  • commit_check/util.py
  • tests/util_test.py

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

github-actions Bot added chore tests Add test related changes labels Jul 29, 2026
shenxianpeng removed the tests Add test related changes label Jul 29, 2026

sonarqubecloud Bot commented Jul 29, 2026

Copy link
Copy Markdown

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

codecov Bot commented Jul 29, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.28%. Comparing base (ad606e1) to head (656e658).

Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #484      +/-   ##
==========================================
+ Coverage   97.20%   97.28%   +0.07%     
==========================================
  Files          12       12              
  Lines        1182     1177       -5     
==========================================
- Hits         1149     1145       -4     
+ Misses         33       32       -1

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

shenxianpeng merged commit cb0c44f into main Jul 29, 2026
32 checks passed
shenxianpeng deleted the chore/remove-dead-code-find-check branch July 29, 2026 20:42

codspeed-hq Bot commented Jul 29, 2026

Copy link
Copy Markdown

Merging this PR will improve performance by 62.54%

⚠️ Different runtime environments detected

Some benchmarks with significant performance changes were compared across different runtime environments,
which may affect the accuracy of the results.

Open the report in CodSpeed to investigate

⚡ 1 improved benchmark
✅ 381 untouched benchmarks
⏩ 114 skipped benchmarks1

Performance Changes

Benchmark BASE HEAD Efficiency
⚡ test_empty_message_passes 1,217.2 µs 748.9 µs +62.54%

Tip

Curious why this is faster? Comment @codspeedbot explain why this is faster on this PR, or directly use the CodSpeed MCP with your agent.

Comparing chore/remove-dead-code-find-check (656e658) with main (ad606e1)

Footnotes

  1. 114 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

chore

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

Back | FazBrowse Home | New Git URL