FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

chore(deps): bump commit-check from 2.13.1 to 2.13.3 by dependabot[bot] · Pull Request #258 · commit-check/commit-check-action · GitHub

chore(deps): bump commit-check from 2.13.1 to 2.13.3 - #258

Closed
dependabot[bot] wants to merge 1 commit into
mainfrom
dependabot/pip/commit-check-2.13.3
Closed

chore(deps): bump commit-check from 2.13.1 to 2.13.3#258
dependabot[bot] wants to merge 1 commit into
mainfrom
dependabot/pip/commit-check-2.13.3

Conversation

dependabot Bot commented on behalf of github Aug 7, 2026

Copy link
Copy Markdown
Contributor

Bumps commit-check from 2.13.1 to 2.13.3.

Release notes

Sourced from commit-check's releases.

v2.13.3

What's Changed

🐛 Bug fixes

📝 Documentation

Full Changelog: commit-check/commit-check@v2.13.2...v2.13.3

v2.13.2

What's Changed

🐛 Bug fixes

📝 Documentation

  • docs: refresh the demo recording, and fix a tape that recorded a false pass by @​shenxianpeng in #530

👻 Maintenance

Full Changelog: commit-check/commit-check@v2.13.1...v2.13.2

Commits
  • 90c5abe docs: refresh README sample output to match what commit-check prints (#535)
  • 08d14c1 fix: distinguish an absent commit message from an empty one (#534)
  • 98fb97c fix: resolve merge-base refs that exist only on the remote (#532)
  • e2edc16 docs: refresh the demo recording, and fix a tape that recorded a false pass (...
  • 7315edf fix: print the display name in compact output, not the config key (#529)
  • 1072b87 chore: expand imperative verb whitelist and improve validation logic (#527)
  • See full diff in compare view

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [commit-check](https://github.com/commit-check/commit-check) from 2.13.1 to 2.13.3.
- [Release notes](https://github.com/commit-check/commit-check/releases)
- [Commits](commit-check/commit-check@v2.13.1...v2.13.3)

---
updated-dependencies:
- dependency-name: commit-check
  dependency-version: 2.13.3
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
dependabot Bot added dependencies Pull requests that update a dependency file patch A patch version bump python Pull requests that update Python code labels Aug 7, 2026
dependabot Bot requested a review from a team as a code owner August 7, 2026 10:10
dependabot Bot requested a review from shenxianpeng August 7, 2026 10:10
dependabot Bot added dependencies Pull requests that update a dependency file python Pull requests that update Python code patch A patch version bump labels Aug 7, 2026

github-actions Bot commented Aug 7, 2026

Copy link
Copy Markdown
Contributor

Commit Check

All 5 checks passed

Show all 5 checks
Commit message
  ✔ PR title
  ✔ Commit 1/1
Branch
  ✔ Branch
Author
  ✔ Author name
  ✔ Author email

commit-check 2.13.3 · Rules reference

shenxianpeng added a commit that referenced this pull request Aug 7, 2026
Review found the same defect this PR set out to fix, one layer down.

run_commit_check has always failed only on "fail", but add_job_summary,
add_pr_comments (two call sites) and set_result_output each asked
`all(scope.status == "pass")` instead. Those were equivalent only while
pass and fail were the only statuses. With skip added, a skipped-only run
rendered "⊘ All N checks skipped" and then exited 1 and emitted result
status "fail" -- a bypassed policy turned into a broken build.

Four copies of a two-state assumption is the same shape as the four copies
of the reduce-to-overall rule in commit-check#537, so it gets the same
remedy: overall_status() and exit_code_for(), defined once and used by
every path.

Three smaller findings, all real:

* _markdown_table skipped only `pass` scopes, so a run with both a failure
  and a skip added a row with no value and no rule links -- a blank
  accusation under a "Failed checks" heading. It now takes failures only.
* The all-skipped verdict fired on an empty result set, where
  `skipped == total` is trivially true, reporting "All 0 checks skipped".
  It now requires a scope, matching the guard the step log already had.
* The step log said "all checks passed (2 skipped)" for a partial skip,
  contradicting its own report headline. It now reads
  "2 of 3 checks passed, 1 skipped".

Each fix is pinned by a test that fails when the fix is reverted, checked
one at a time.

Not changed: the requirements.txt pin. The README documents 2.13.4 as the
minimum for ⊘ to appear, and 2.13.4 does not exist yet -- commit-check#537
is still open. Pinning it now would install a version that cannot be
resolved. The rendering is back-compatible by construction, so the bump
belongs with the release, not here.

The subject avoids "treat", which reads as imperative but is absent from
the 396-verb list in commit-check 2.13.1 -- the version this action still
pins. It was added by commit-check#527 and shipped in 2.13.2, so the
whitelist on the runner is three releases behind the project's own. The
pin bump in #258 fixes that; this only sidesteps it.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01U9zFxq8V4qxG4aMzJhGBFn
shenxianpeng added a commit that referenced this pull request Aug 7, 2026
PR #258 in this repository reported "All 5 checks passed" over five green
ticks while validating nothing: its author is dependabot[bot], which the
org config lists in ignore_authors, so every rule was bypassed. The report
had no way to say so -- ScopeResult knew only pass and fail, and a skip
arrived looking exactly like a pass.

The bare labels in that summary were the only hint anything was different,
and only because a skipped check reports no value. That was incidental, not
a signal.

commit-check 2.13.4 reports "status": "skip", so this consumes it:

  * ScopeResult.status gains "skip", set when every check in the scope
    skipped. One real verdict outranks the skips.
  * Skipped scopes render "⊘ <label> (skipped)" -- deliberately not a ✔,
    and with no value, because nothing was examined.
  * The headline distinguishes the three cases. All skipped reads
    "⊘ All N checks skipped — nothing was validated"; a partial skip reads
    "✅ 3 of 5 checks passed, 2 skipped" rather than claiming all passed.
  * The step log line follows the same rule.

Back-compatible by construction: against an engine that never emits "skip"
no branch here is reachable, and a test pins that the old rendering is
unchanged.

Adds a golden test for the fully skipped report so the layout stays exact,
alongside tests for the partial-skip headline, failure precedence, and the
one-real-verdict rule. The output specification comment and the README gain
the skipped case, the README's rendered from the real renderer.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01U9zFxq8V4qxG4aMzJhGBFn
shenxianpeng added a commit that referenced this pull request Aug 7, 2026
Review found the same defect this PR set out to fix, one layer down.

run_commit_check has always failed only on "fail", but add_job_summary,
add_pr_comments (two call sites) and set_result_output each asked
`all(scope.status == "pass")` instead. Those were equivalent only while
pass and fail were the only statuses. With skip added, a skipped-only run
rendered "⊘ All N checks skipped" and then exited 1 and emitted result
status "fail" -- a bypassed policy turned into a broken build.

Four copies of a two-state assumption is the same shape as the four copies
of the reduce-to-overall rule in commit-check#537, so it gets the same
remedy: overall_status() and exit_code_for(), defined once and used by
every path.

Three smaller findings, all real:

* _markdown_table skipped only `pass` scopes, so a run with both a failure
  and a skip added a row with no value and no rule links -- a blank
  accusation under a "Failed checks" heading. It now takes failures only.
* The all-skipped verdict fired on an empty result set, where
  `skipped == total` is trivially true, reporting "All 0 checks skipped".
  It now requires a scope, matching the guard the step log already had.
* The step log said "all checks passed (2 skipped)" for a partial skip,
  contradicting its own report headline. It now reads
  "2 of 3 checks passed, 1 skipped".

Each fix is pinned by a test that fails when the fix is reverted, checked
one at a time.

Not changed: the requirements.txt pin. The README documents 2.13.4 as the
minimum for ⊘ to appear, and 2.13.4 does not exist yet -- commit-check#537
is still open. Pinning it now would install a version that cannot be
resolved. The rendering is back-compatible by construction, so the bump
belongs with the release, not here.

The subject avoids "treat", which reads as imperative but is absent from
the 396-verb list in commit-check 2.13.1 -- the version this action still
pins. It was added by commit-check#527 and shipped in 2.13.2, so the
whitelist on the runner is three releases behind the project's own. The
pin bump in #258 fixes that; this only sidesteps it.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01U9zFxq8V4qxG4aMzJhGBFn
shenxianpeng added a commit that referenced this pull request Aug 7, 2026
PR #258 in this repository reported "All 5 checks passed" over five green
ticks while validating nothing: its author is dependabot[bot], which the
org config lists in ignore_authors, so every rule was bypassed. The report
had no way to say so -- ScopeResult knew only pass and fail, and a skip
arrived looking exactly like a pass.

The bare labels in that summary were the only hint anything was different,
and only because a skipped check reports no value. That was incidental, not
a signal.

commit-check 2.13.4 reports "status": "skip", so this consumes it:

  * ScopeResult.status gains "skip", set when every check in the scope
    skipped. One real verdict outranks the skips.
  * Skipped scopes render "⊘ <label> (skipped)" -- deliberately not a ✔,
    and with no value, because nothing was examined.
  * The headline distinguishes the three cases. All skipped reads
    "⊘ All N checks skipped — nothing was validated"; a partial skip reads
    "✅ 3 of 5 checks passed, 2 skipped" rather than claiming all passed.
  * The step log line follows the same rule.

Back-compatible by construction: against an engine that never emits "skip"
no branch here is reachable, and a test pins that the old rendering is
unchanged.

Adds a golden test for the fully skipped report so the layout stays exact,
alongside tests for the partial-skip headline, failure precedence, and the
one-real-verdict rule. The output specification comment and the README gain
the skipped case, the README's rendered from the real renderer.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01U9zFxq8V4qxG4aMzJhGBFn
shenxianpeng added a commit that referenced this pull request Aug 7, 2026
Review found the same defect this PR set out to fix, one layer down.

run_commit_check has always failed only on "fail", but add_job_summary,
add_pr_comments (two call sites) and set_result_output each asked
`all(scope.status == "pass")` instead. Those were equivalent only while
pass and fail were the only statuses. With skip added, a skipped-only run
rendered "⊘ All N checks skipped" and then exited 1 and emitted result
status "fail" -- a bypassed policy turned into a broken build.

Four copies of a two-state assumption is the same shape as the four copies
of the reduce-to-overall rule in commit-check#537, so it gets the same
remedy: overall_status() and exit_code_for(), defined once and used by
every path.

Three smaller findings, all real:

* _markdown_table skipped only `pass` scopes, so a run with both a failure
  and a skip added a row with no value and no rule links -- a blank
  accusation under a "Failed checks" heading. It now takes failures only.
* The all-skipped verdict fired on an empty result set, where
  `skipped == total` is trivially true, reporting "All 0 checks skipped".
  It now requires a scope, matching the guard the step log already had.
* The step log said "all checks passed (2 skipped)" for a partial skip,
  contradicting its own report headline. It now reads
  "2 of 3 checks passed, 1 skipped".

Each fix is pinned by a test that fails when the fix is reverted, checked
one at a time.

Not changed: the requirements.txt pin. The README documents 2.13.4 as the
minimum for ⊘ to appear, and 2.13.4 does not exist yet -- commit-check#537
is still open. Pinning it now would install a version that cannot be
resolved. The rendering is back-compatible by construction, so the bump
belongs with the release, not here.

The subject avoids "treat", which reads as imperative but is absent from
the 396-verb list in commit-check 2.13.1 -- the version this action still
pins. It was added by commit-check#527 and shipped in 2.13.2, so the
whitelist on the runner is three releases behind the project's own. The
pin bump in #258 fixes that; this only sidesteps it.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01U9zFxq8V4qxG4aMzJhGBFn
shenxianpeng added a commit that referenced this pull request Aug 7, 2026
* feat: render a skipped check as skipped, not as a green tick

PR #258 in this repository reported "All 5 checks passed" over five green
ticks while validating nothing: its author is dependabot[bot], which the
org config lists in ignore_authors, so every rule was bypassed. The report
had no way to say so -- ScopeResult knew only pass and fail, and a skip
arrived looking exactly like a pass.

The bare labels in that summary were the only hint anything was different,
and only because a skipped check reports no value. That was incidental, not
a signal.

commit-check 2.13.4 reports "status": "skip", so this consumes it:

  * ScopeResult.status gains "skip", set when every check in the scope
    skipped. One real verdict outranks the skips.
  * Skipped scopes render "⊘ <label> (skipped)" -- deliberately not a ✔,
    and with no value, because nothing was examined.
  * The headline distinguishes the three cases. All skipped reads
    "⊘ All N checks skipped — nothing was validated"; a partial skip reads
    "✅ 3 of 5 checks passed, 2 skipped" rather than claiming all passed.
  * The step log line follows the same rule.

Back-compatible by construction: against an engine that never emits "skip"
no branch here is reachable, and a test pins that the old rendering is
unchanged.

Adds a golden test for the fully skipped report so the layout stays exact,
alongside tests for the partial-skip headline, failure precedence, and the
one-real-verdict rule. The output specification comment and the README gain
the skipped case, the README's rendered from the real renderer.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01U9zFxq8V4qxG4aMzJhGBFn

* fix: stop reporting a skipped run as a failure

Review found the same defect this PR set out to fix, one layer down.

run_commit_check has always failed only on "fail", but add_job_summary,
add_pr_comments (two call sites) and set_result_output each asked
`all(scope.status == "pass")` instead. Those were equivalent only while
pass and fail were the only statuses. With skip added, a skipped-only run
rendered "⊘ All N checks skipped" and then exited 1 and emitted result
status "fail" -- a bypassed policy turned into a broken build.

Four copies of a two-state assumption is the same shape as the four copies
of the reduce-to-overall rule in commit-check#537, so it gets the same
remedy: overall_status() and exit_code_for(), defined once and used by
every path.

Three smaller findings, all real:

* _markdown_table skipped only `pass` scopes, so a run with both a failure
  and a skip added a row with no value and no rule links -- a blank
  accusation under a "Failed checks" heading. It now takes failures only.
* The all-skipped verdict fired on an empty result set, where
  `skipped == total` is trivially true, reporting "All 0 checks skipped".
  It now requires a scope, matching the guard the step log already had.
* The step log said "all checks passed (2 skipped)" for a partial skip,
  contradicting its own report headline. It now reads
  "2 of 3 checks passed, 1 skipped".

Each fix is pinned by a test that fails when the fix is reverted, checked
one at a time.

Not changed: the requirements.txt pin. The README documents 2.13.4 as the
minimum for ⊘ to appear, and 2.13.4 does not exist yet -- commit-check#537
is still open. Pinning it now would install a version that cannot be
resolved. The rendering is back-compatible by construction, so the bump
belongs with the release, not here.

The subject avoids "treat", which reads as imperative but is absent from
the 396-verb list in commit-check 2.13.1 -- the version this action still
pins. It was added by commit-check#527 and shipped in 2.13.2, so the
whitelist on the runner is three releases behind the project's own. The
pin bump in #258 fixes that; this only sidesteps it.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01U9zFxq8V4qxG4aMzJhGBFn

---------

Co-authored-by: Claude Opus 5 <noreply@anthropic.com>

dependabot Bot commented on behalf of github Aug 7, 2026

Copy link
Copy Markdown
Contributor Author

Superseded by #263.

dependabot Bot closed this Aug 7, 2026
dependabot Bot deleted the dependabot/pip/commit-check-2.13.3 branch August 7, 2026 12:34
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file patch A patch version bump python Pull requests that update Python code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant


Back | FazBrowse Home | New Git URL