chore: update find-node-modules to 2.1.0, fixing security warning - #753
Closed
callumacrae wants to merge 1 commit into
Closed
chore: update find-node-modules to 2.1.0, fixing security warning#753callumacrae wants to merge 1 commit into
callumacrae wants to merge 1 commit into
Conversation
Copy link
Copy Markdown
Sorry, something went wrong.
PR fixing the issue on find-node-modules: callumacrae/find-node-modules#11
jimmyandrade
approved these changes
Aug 21, 2020
jimmyandrade
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
LGTM
Sorry, something went wrong.
Copy link
Copy Markdown
|
Looks like this can be closed since #808 supersedes it with a newer version. |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
1 more reviewer4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following #609, it looks like it happened again - there was another issue in findup-sync!
PR fixing the issue on find-node-modules: callumacrae/find-node-modules#11
findup-sync@4.0.0 has dropped support for node 8, but looking at your README it doesn't look like that will be an issue.
(also this PR was my first time using commitizen - I liked it! 😆)