Attempt at Supporting Overriding Core Delimiter Processors - #432
Open
rdestefa wants to merge 1 commit into
Open
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
rdestefa
force-pushed
the
issue-386-override-default-delimiter-processor
branch
from
97f4b43 to
8a1d8f7
Compare
May 2, 2026 09:05
Copy link
Copy Markdown
Collaborator
|
Instead of a separate configuration, can you explore how it would look if the normal customDelimiterProcessor would just be able to override built-in ones? I think we'd still want to error if a user accidentally specifies two processors with the same configuration, but not if they override a built-in one (i.e. add the custom ones first, then add the built-in ones if they don't have conflicts). |
Sorry, something went wrong.
robinst
requested changes
Jun 20, 2026
robinst
left a comment
Copy link
Copy Markdown
Collaborator
There was a problem hiding this comment.
See comment above
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Quick attempt at supporting #386. Not sure if I've covered all edge cases or if there's a simpler way to do this, so might come back to this later.