MarkdownWriter: append unescaped spans in bulk - #456
Open
tballison wants to merge 2 commits into
Open
tballison wants to merge 2 commits into
tballison wants to merge 2 commits into
Conversation
Copy link
Copy Markdown
Sorry, something went wrong.
roxspring
reviewed
Sep 7, 2026
Comment thread
commonmark/src/main/java/org/commonmark/renderer/markdown/MarkdownWriter.java
Outdated
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
1 more reviewer2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
During profiling after the release of Tika 4.0.0, we found we could improve write speed quite a bit in cases where there weren't a lot of characters that needed to be escaped.
🤖
JMH, whole CommonMark spec (SpecBenchmark, JDK 17, -f 3 -wi 8 -i 12)
Rendering 4.7 MB of plain prose (best-of-22 after warmup, JDK 17)
Same measurement, 4.0 MB of the spec (escape-dense, closer to a worst case)