Fix code spans after an unclosed backtick string - #459
Open
TanbirRamim wants to merge 1 commit into
Open
TanbirRamim wants to merge 1 commit into
TanbirRamim wants to merge 1 commit into
Conversation
Copy link
Copy Markdown
Sorry, something went wrong.
After scanning to the end for an unclosed backtick string, the parser overwrote the cached last position of each backtick run length while parsing later code spans. A later opener of the same length then looked like it had no closer and was left as text. Fixes commonmark#458
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With an unclosed backtick string before two code spans, like `` a `c`, the second code span was rendered as text. Parsing the first span overwrote the cached closer position that was recorded when the unclosed string scanned to the end, so the later opener looked unmatched. The cache is now only updated before that full scan. I added a test in SpecialInputTest, and the commonmark module tests pass. Fixes #458.