FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Add more colors by tiberiugila · Pull Request #199 · console-rs/console · GitHub

Add more colors - #199

Open
tiberiugila wants to merge 3 commits into
console-rs:mainfrom
tiberiugila:master
Open

tiberiugila wants to merge 3 commits into
console-rs:mainfrom
tiberiugila:master

Conversation

Copy link
Copy Markdown

Fixed #177 also added the first 16 colors to the color enum

alexandruradovici left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Delete the .idea folder.

Copy link
Copy Markdown

Please change the title to your pull request to briefly reflect what it does.

tiberiugila changed the title Fixed https://github.com/console-rs/console/issues/177 Fixed https://github.com/console-rs/console/issues/177(fixed white color and added the first 16 colors to the color enum) Jan 21, 2024
Comment thread src/utils.rs

jarjk commented May 6, 2025

Copy link
Copy Markdown

I'd highly appreciate seeing this merged, as it'd help my work on creating a ratatui console backend.
is there anything I can help with?

Comment thread src/utils.rs
self.fg(Color::Aqua)
}
#[inline]
pub fn brightwhite(self) -> Style {

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

This (and on_brightwhite()) should use bright_white to match the naming conventions.

djc changed the title Fixed https://github.com/console-rs/console/issues/177(fixed white color and added the first 16 colors to the color enum) Add more colors May 6, 2025

djc commented May 6, 2025

Copy link
Copy Markdown
Member

I'd highly appreciate seeing this merged, as it'd help my work on creating a ratatui console backend. is there anything I can help with?

@JeromeSchmied I started to help maintaining this crate in December and have been doing passive maintenance (mostly because I am an indicatif maintainer and this is a dependency of that crate). Since this hadn't been touched for a while, I didn't spend time on it. It looks fairly straightforward to me so I think we can merge this once the naming issue has been fixed.

I don't know if @tiberiugila is still interested in following up, if they don't respond in a week or so feel free to take this PR and resubmit it.

jarjk commented May 6, 2025

Copy link
Copy Markdown

fair enough, thanks for checking!

Copy link
Copy Markdown

I don't want to dunk on anyone's work, we're all doing this for free here, but how about we actually name colors meaningfully like it's done by owo_colors.

Having bright variants of base colors like red, green, yellow and blue would be much more useful than trying to guess what is Navy, Fuchsia, Maroon or others.

Copy link
Copy Markdown

I'm open for submitting the PR myself, it just really bugs me that my indicatif progress bars are stuck with whatever we currently have while owo_colors is living it large.

And they also have NO_COLOR env variable support...

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

white isn't white

6 participants


Back | FazBrowse Home | New Git URL