FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

alternate screen (fixes #63) by aeosynth · Pull Request #65 · console-rs/console · GitHub

alternate screen (fixes #63) - #65

Open
aeosynth wants to merge 2 commits into
console-rs:mainfrom
aeosynth:alternate
Open

aeosynth wants to merge 2 commits into
console-rs:mainfrom
aeosynth:alternate

Conversation

Copy link
Copy Markdown

Please review.

aeosynth commented May 20, 2020
edited
Loading

Copy link
Copy Markdown
Author

ok I don't know what the (legacy?) windows api for alternate screen is. the added functions in windows_term.rs don't handle the case where out.is_msys_tty is false.

pksunkara linked an issue May 20, 2020 that may be closed by this pull request

Copy link
Copy Markdown
Collaborator

Copy link
Copy Markdown
Collaborator

@aeosynth Any update on this?

Archina pushed a commit to Archina/console that referenced this pull request Apr 5, 2021
dtolnay pushed a commit to dtolnay-contrib/console that referenced this pull request Feb 4, 2022
…s#65)

With it only having a "max" of 24, if the chart needed to take up more
space, it would use up all of it and the percentile window would be
gone.

Copy link
Copy Markdown

Do I understand correctly that the only thing missing from this PR is support for legacy Windows terminals?

Copy link
Copy Markdown
Collaborator

For what it's worth if it works on any windows terminal that's probably good enough if sufficient documentation is added. If you can make mergeable and add documentation it should be fine to merge.

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

alternate screen

4 participants


Back | FazBrowse Home | New Git URL