FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Remove esbuild@0.11.x from dependency list by nayaabkhan · Pull Request #204 · contentlayerdev/contentlayer · GitHub

/ contentlayer Public

Remove esbuild@0.11.x from dependency list - #204

Merged
schickling merged 2 commits into
contentlayerdev:mainfrom
nayaabkhan:patch-1
May 11, 2022
ConversationCommits (2)ChecksFiles changed
Merged

Remove esbuild@0.11.x from dependency list#204
schickling merged 2 commits into
contentlayerdev:mainfrom
nayaabkhan:patch-1

Conversation

nayaabkhan commented Apr 30, 2022

Copy link
Copy Markdown
Contributor

No description provided.

changeset-bot Bot commented Apr 30, 2022 •
edited
Loading

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 36afcfb

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

nayaabkhan commented Apr 30, 2022
View reviewed changes
Comment thread packages/@contentlayer/core/package.json
"peerDependencies": {
"date-fns": "2.x",
"esbuild": "0.11.x || 0.12.x || 0.13.x",
"esbuild": "^0.12.1 || 0.13.x",

nayaabkhan Apr 30, 2022

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I've not tested if this way of specifying the versions works.

nayaabkhan commented Apr 30, 2022
View reviewed changes
Comment thread packages/@contentlayer/core/package.json
"comment-json": "^4.2.2",
"date-fns": "2.x",
"esbuild": "0.11.x || 0.12.x || 0.13.x || 0.14.x",
"esbuild": "^0.12.1 || 0.13.x || 0.14.x",

nayaabkhan Apr 30, 2022

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I've not tested if this way of specifying the versions works.

schickling commented Apr 30, 2022

Copy link
Copy Markdown
Collaborator

Could you please provide some explanation/motivation for this change? Which problem are you trying to address with this? (Please refer to the corresponding issues.)

nayaabkhan commented May 1, 2022

Copy link
Copy Markdown
Contributor Author

Reproduction repo: #205 (comment)

nayaabkhan commented May 2, 2022

Copy link
Copy Markdown
Contributor Author

Could you please provide some explanation/motivation for this change? Which problem are you trying to address with this? (Please refer to the corresponding issues.)

This change fixes an error caused by older version of esbuild. See #205.

schickling marked this pull request as ready for review May 11, 2022 09:04
schickling merged commit c60847c into contentlayerdev:main May 11, 2022
nayaabkhan deleted the patch-1 branch May 11, 2022 09:06

schickling commented May 11, 2022

Copy link
Copy Markdown
Collaborator

Thanks a lot for this PR and corresponding issue! Very helpful! 🙏

Will be released as part of the upcoming 0.2.5.

nayaabkhan commented May 11, 2022

Copy link
Copy Markdown
Contributor Author

No problemo! Very happy to help out.

schickling added this to the 0.2.5 milestone May 11, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

0.2.5

Development

Successfully merging this pull request may close these issues.

2 participants

Back | FazBrowse Home | New Git URL