feat: added changes for seq_id - #29
Conversation
ishaileshmishra
left a comment
There was a problem hiding this comment.
@vkalta, https://github.com/contentstack/contentstack-ios/blob/a2f87854f0c0a2232d653b39a52f5126a70e6ea1/ContentstackInternal/BSONObjectIdGenerator.m
seq_id generation using bason lib should be inside the persistence sdk not here. this is part of persistence
Sorry, something went wrong.
By the design currently the seq id, sync token and pagination is currently being updated inside the contentstack-ios project. This is why it was deemed to be added here and not in persistence package. Please let me know your thoughts on it. Thanks |
Sorry, something went wrong.
|
|
||
| @param completionBlock called synchronization is done. | ||
| */ | ||
| - (void)syncSeqIdInit:(void (^)(SyncStack * BUILT_NULLABLE_P syncStack, NSError * BUILT_NULLABLE_P error))completionBlock; |
There was a problem hiding this comment.
The function should be named initSeqSync or initialSequenceSync.
Reasoning: Including "id" in the function name may cause confusion for developers as it doesn't serve any purpose in this context. This function doesn't require any input from the developer.
Sorry, something went wrong.
ishaileshmishra
left a comment
There was a problem hiding this comment.
Approved
thanks @vkalta
Sorry, something went wrong.
|
@vkalta , approved but before merging the PR make sure to add below changes :
thank you ! |
Sorry, something went wrong.
Reviewers
1 more reviewerAt least 1 approving review is required to merge this pull request.
This PR is a enhancement task with respect to the previous sync API implementation by replacing sync token with seq id.