Fix BView detach callback dispatch - #18
Open
cyberman wants to merge 1 commit into
Open
cyberman wants to merge 1 commit into
cyberman wants to merge 1 commit into
Conversation
Copy link
Copy Markdown
Sorry, something went wrong.
Dispatch DetachedFromWindow and AllDetached to their matching Python overrides instead of AllAttached. Add a regression test that exercises both C++ trampoline paths and verifies the callbacks received by a Python BView subclass.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The BView trampolines for DetachedFromWindow() and AllDetached() both dispatch to the Python AllAttached() override.
Python subclasses therefore receive the wrong lifecycle callback when a view is detached.
Fix
Dispatch each trampoline to its matching Python override.
Validation
Verified that the bound base methods now invoke DetachedFromWindow() followed by AllDetached().