Activate BSplitView binding - #24
Open
cyberman wants to merge 1 commit into
Open
cyberman wants to merge 1 commit into
cyberman wants to merge 1 commit into
Conversation
Copy link
Copy Markdown
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
SplitView.cpp exists but is not included in the Jam build or exported by the Be package, so BSplitView is unavailable to Python callers.
Enabling the source also exposes incomplete layout types, incorrect bindings for the const ItemWeight() overloads, and an owning holder that conflicts with BWindow ownership.
Fix
Add SplitView.cpp to the build and package exports, include the complete layout types, bind both const overloads with py::const_, and use a py::nodelete holder.
Validation
Verified that SplitView.so builds and imports successfully and that a window-owned BSplitView shuts down without an allocator abort.