Added corbench code without manifest files - #2
TheKongers wants to merge 2 commits into
Conversation
Sorry, something went wrong.
| @@ -0,0 +1,16 @@ | |||
| FROM --platform=linux/amd64 golang:1.15-alpine | |||
There was a problem hiding this comment.
Can we use newer version of golang?
Sorry, something went wrong.
| name: gp2-csi | ||
| provisioner: ebs.csi.aws.com | ||
| parameters: | ||
| type: gp2 |
There was a problem hiding this comment.
Why not GP3?
Sorry, something went wrong.
There was a problem hiding this comment.
I could use gp3, but i wonder if it will break, i will give it a test
Sorry, something went wrong.
| @@ -0,0 +1,18 @@ | |||
| # Build stage | |||
| FROM golang:1.15-alpine AS builder | |||
There was a problem hiding this comment.
Use go 1.24.x
Sorry, something went wrong.
|
|
||
| type Resource = provider.Resource | ||
|
|
||
| type eksCluster struct { |
There was a problem hiding this comment.
Do we really need these code? Can we just import prombench as a library
Sorry, something went wrong.
| "github.com/cortexproject/test-infra/corbench/pkg/provider" | ||
| ) | ||
|
|
||
| func init() { |
There was a problem hiding this comment.
ditto. If we cannot reuse prombench CLI, let's try to use its library instead of copy its code directly.
Sorry, something went wrong.
| set -e | ||
|
|
||
| # Disable AWS CLI pager to prevent interactive prompts | ||
| export AWS_PAGER="" |
There was a problem hiding this comment.
It is ok to keep this script for now but we should try to just configure EBS CSI addon in the same eks cluster yaml
Sorry, something went wrong.
There was a problem hiding this comment.
I will add a note
Sorry, something went wrong.
Signed-off-by: Eric Kong <erikong@amazon.com>
Signed-off-by: Eric Kong <erikong@amazon.com>
|
Hi ben! I would like to continue getting this in the repo when I have some spare time, but I don't have resources for testing changes anymore, Is there some way I could get aws credits? |
Sorry, something went wrong.
|
@yeya24 anything blocking us from merging this code for now? |
Sorry, something went wrong.
Moved over all corbench code from https://github.com/TheKongers/Corbench without the manifest files.
NOTE: the files under the directories /corbench/infra and /corbench/pkg are directly from prombench, but trimmed down to only keep the EKS functionality to make it more lightweight.