FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Ignore exclusions inside multiline strings by puneetdixit200 · Pull Request #2180 · coveragepy/coveragepy · GitHub

/ coveragepy Public

Ignore exclusions inside multiline strings - #2180

Open
puneetdixit200 wants to merge 7 commits into
coveragepy:mainfrom
puneetdixit200:fix-ellipsis-string-exclusion
ConversationCommits (7)ChecksFiles changed
Open

Ignore exclusions inside multiline strings#2180
puneetdixit200 wants to merge 7 commits into
coveragepy:mainfrom
puneetdixit200:fix-ellipsis-string-exclusion

Conversation

puneetdixit200 commented May 23, 2026

Copy link
Copy Markdown

Summary:

  • prevent exclusion regex matches inside string tokens from excluding the containing statement
  • add regression tests for YAML-style multiline literals and single-line string literals containing ...
  • keep real pragma comments on string assignment lines covered

Tests:

  • PYTHONWARNDEFAULTENCODING= /tmp/coveragepy-venv/bin/python -m pytest -q tests/test_coverage.py::ExcludeTest::test_default_ellipsis_exclusion_ignores_multiline_strings tests/test_coverage.py::ExcludeTest::test_default tests/test_parser.py::ExclusionParserTest::test_over_exclusion_bug1779
  • PYTHONWARNDEFAULTENCODING= /tmp/coveragepy-venv/bin/python -m pytest -q tests/test_coverage.py::ExcludeTest
  • PYTHONWARNDEFAULTENCODING= /tmp/coveragepy-venv/bin/python -m pytest -q tests/test_parser.py::ExclusionParserTest
  • /tmp/coveragepy-venv/bin/python -m compileall -q coverage/parser.py tests/test_coverage.py
  • git diff --check

Supersedes #2177
Fixes #2112

Ignore exclusions inside multiline strings
b53ec59
test: cover single-line exclusion strings
b0c5c2a 
Add explicit coverage showing default ellipsis exclusion patterns inside single-line strings are ignored while real pragma comments on the same line still exclude.
Format exclusion string test
dc90988
Preserve multiline string pragma exclusions
1bfc82a
puneetdixit200 mentioned this pull request May 24, 2026
Closed
nedbat reviewed Jun 28, 2026
View reviewed changes
Comment thread coverage/parser.py
ltext,
)
)
if toktype == token.STRING and slineno != elineno:

nedbat Jun 28, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

This doesn't seem right to me: This is saying that any lines that are part of a multi-line string won't be excluded. That's not taking into account what else is on those lines, or whether the multi-line string matched one of the exclusion rules.

For example, this test fails:

        self.check_coverage(
            """\
            a = 1
            ignore_var = "2"
            ignore_var = '''
                3,4,5
                '''
            ignore_var = "6"
            a = 7
            """,
            excludes=["ignore_var"],
            lines=[1, 7],
        )

nedbat Jun 28, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I've added this as a test.

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

nedbat nedbat left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Default ... exclusion can exclude things by accident

2 participants

Back | FazBrowse Home | New Git URL