unit-test BranchArcResolver directly - #2228
Open
reaperhulk wants to merge 1 commit into
Open
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
The resolver runs inside the tracer, so nothing tested it directly. Add directed tests pinning each behavior of resolve()'s contract, running on 3.14+ where the sysmon core actually uses the resolver, plus an agreement test (3.13+) checking its raw byte-walking (CACHE and EXTENDED_ARG handling, jump-target arithmetic) against an independent dis-based reference on both destinations of every conditional jump in a corpus: the compiled source of argparse and dataclasses (~1250 branch pairs, expected arcs computed by the reference at runtime), plus four snippets guaranteeing match/case, async generators, except*, and EXTENDED_ARG-sized jumps. Because the compiler chooses freely between jump-on-true and jump-on-false, the directed tests locate branches by source line and, where polarity isn't pinned down, assert the set of arcs from both destinations. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0137DLbSXfm5v5bhCcz7xEKM
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR was generated via claude but has undergone review before submission. However, we may want to iterate further before merging here.
The resolver runs inside the tracer, which causes coverage issues. This PR adds tests against resove() on 3.14+ where the sysmon core actually uses the resolver, plus an agreement test (3.13+) checking its raw byte-walking (CACHE and EXTENDED_ARG handling, jump-target arithmetic) against an independent dis-based reference on both destinations of every conditional jump in a corpus: the compiled source of argparse and dataclasses (~1250 branch pairs, expected arcs computed by the reference at runtime), plus four snippets guaranteeing match/case, async generators, except*, and EXTENDED_ARG-sized jumps.