Generate implicit relative-path aliases for every directory component instead of only the first component.
Add a regression test for a combined path whose usable local source is a deeper existing suffix.
Why
With relative_files = true, the first relative filename seen during combine could generate an alias such as */work -> work/. If that target did not exist locally, the path stayed unchanged even when a deeper suffix such as src/pkg/module.py did exist. Because input file ordering can vary, this produced intermittent No source for code errors.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Why
With relative_files = true, the first relative filename seen during combine could generate an alias such as */work -> work/. If that target did not exist locally, the path stayed unchanged even when a deeper suffix such as src/pkg/module.py did exist. Because input file ordering can vary, this produced intermittent No source for code errors.
Fixes #2195
Tests