test: restore HTML JavaScript test suite - #2272
Conversation
Sorry, something went wrong.
Update the QUnit fixture to match the current pyfile markup and remove references to deleted jQuery assets. Replace the old jQuery helpers with native DOM APIs so the existing navigation assertions run again. Restoring the suite also exposes a boundary error in to_prev_chunk when the previous highlighted chunk starts on line 1; fix that case while preserving the existing selection behavior. OpenAI Codex assisted with the implementation and verification of this change.
yangfan-yf-yf
left a comment
There was a problem hiding this comment.
I rechecked d174051. The fixture matches the current p > span.n > a markup, the native DOM helpers preserve the existing assertions, and the previous-chunk scan correctly retains a chunk beginning on line 1.
In a local Chromium run, the QUnit page completed 96 tests / 253 assertions with no failures or console warnings. On Windows with Python 3.12, tests/test_html.py completed with 66 passed and one platform-specific skip. Both JavaScript syntax checks and git diff --check passed.
The repository checks currently do not execute tests/js; adding a headless entry point would be a useful follow-up, as would removing the now-unreferenced tests/qunit/jquery.tmpl.min.js. Neither affects the requested suite restoration or boundary fix.
Sorry, something went wrong.
In #2257, Ned asked for a separate PR to get coverage.py's JavaScript tests working again. The suite was stopping before it could run because tests/js/index.html still loaded local jQuery and template files that have been removed from the repository.
This PR:
This is intentionally separate from the percentage calculation work in #2257 and #2259.
Verification
OpenAI Codex assisted with the implementation and verification of this change.